Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 185747 - [Edit] Screen cheese in margins after scrolling in text compare editor
Summary: [Edit] Screen cheese in margins after scrolling in text compare editor
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-Compare-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-07 08:45 EDT by Markus Keller CLA
Modified: 2020-04-16 03:19 EDT (History)
4 users (show)

See Also:


Attachments
Screenshot (101.55 KB, image/png)
2007-05-07 08:47 EDT, Markus Keller CLA
no flags Details
Screenshot#2 (13.69 KB, image/png)
2009-12-07 10:22 EST, Tomasz Zarna CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2007-05-07 08:45:10 EDT
3.3 M7

- new workspace
- check out org.eclipse.core.expressions from dev.eclipse.org
- compare revisions 1.6 and 1.7 of ElementHandler.java
- scroll down a few lines
=> screen cheese at the borders of the editors (2px of connector lines stay)
Comment 1 Markus Keller CLA 2007-05-07 08:47:01 EDT
Created attachment 66091 [details]
Screenshot

See also bug 181177 and bug 181168.
Comment 2 Michael Valenta CLA 2007-05-07 09:15:01 EDT
Markus, the picture you attached is garbled. Could you reattach it?
Comment 3 Markus Keller CLA 2007-05-07 10:00:22 EDT
Comment on attachment 66091 [details]
Screenshot

Oops, I accidentially marked the image as patch...
Comment 4 Michael Valenta CLA 2007-05-08 15:40:02 EDT
I am not able to reproduce this. Is it still happening for you with the steps you outlined?
Comment 5 Markus Keller CLA 2007-05-09 08:37:31 EDT
Yes, I can still reproduce in clean installs of I20070508-0800 and 3.3M7.
To compare the revisions, I do this:
- select ElementHandler.java in the Package Explorer
- call Show In > History
- select the two revisions
- context menu > Compare with Each Other

After clicking once below the scroll thumb (such that it scrolls down one page), I see the cheese.
Comment 6 Michael Valenta CLA 2007-05-09 10:02:44 EDT
I still can't reproduce this. I have Mylar loaded but I can't see how that would fix the problem for me. One things I noticed is that some of the package name text, when near the edge of the left viewer, looks a bit like cheese but is really just cut off letters. Clearly this is not the case for the screenshot in comment 3 but is the closest I've come to seeing cheese in this scenario. I'll try a fresh install and see if that changes things.
Comment 7 Tomasz Zarna CLA 2008-01-08 09:06:01 EST
I've just did the same steps with no result either. I've been using N20080106-0010 build.
Comment 8 Markus Keller CLA 2008-01-08 09:37:04 EST
Found the necessary condition: RTL support must be enabled. See bug 192481 for a problem description and how to enable right-to-left support.

I guess some painter is missing the additional trim here. Maybe Scrollable.computeTrim(int, int, int, int) could help to find this out.
Comment 9 Tomasz Zarna CLA 2009-12-07 10:22:08 EST
Created attachment 153925 [details]
Screenshot#2

I've just bumped into a very similar screen cheese while playing around with bug 296580, no RTL support required:

- import test project attached to bug 296580 (attachment 153473 [details])
- go to /compare_bug/src/compare/JV_1_100_local.java
- change '@since 3.0' to '@since 3.1' in JavadocView's javadoc
- right click on JavadocView node in Package Explorer, do 'Compare With > Element from Local History'
- pick a revision in the History View
- scroll up
Comment 10 Markus Keller CLA 2009-12-07 11:17:38 EST
(In reply to comment #9)
That's exactly the same problem, but everybody gets it now. In bug 137727, we've added a 2px border on the left of all TextViewers (the same border that you previously only got under Windows with an RTL keyboard language installed).
Comment 11 Dani Megert CLA 2009-12-10 04:33:50 EST
This should get fixed for 3.6.
Comment 12 Pawel Pogorzelski CLA 2010-04-26 05:58:15 EDT
Moving to 3.7.
Comment 13 Markus Keller CLA 2011-02-02 10:19:46 EST
In WhitespaceCharacterPainter 1.21, I've fixed a similar problem by not painting into the margin. But in this case, you should actually paint into the trim. The problem could also be in StyledText (if you don't get a paint event when the StyledText widget is scrolled and the margin is not moved automatically).
Comment 14 Szymon Brandys CLA 2011-03-29 09:07:09 EDT
Moving to 3.8. Sorry.
Comment 15 Malgorzata Janczarska CLA 2011-11-18 05:57:49 EST
I'll try to find time for it in M7.
Comment 16 Szymon Brandys CLA 2012-04-30 05:51:46 EDT
We most likely will not have time to work on that during 3.8 cycle.
Comment 17 Eclipse Genie CLA 2020-04-16 03:19:41 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.