Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 184706 - [Dialogs] FilteredItemsSelectionDialog does not allow to render duplicates like in old Open Type dialog
Summary: [Dialogs] FilteredItemsSelectionDialog does not allow to render duplicates li...
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks: 184693
  Show dependency tree
 
Reported: 2007-04-30 10:56 EDT by Markus Keller CLA
Modified: 2022-01-30 19:05 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2007-04-30 10:56:33 EDT
HEAD, follow-up to bug 184693.

The FilteredItemsSelectionDialog does not allow to render duplicates like in the old Open Type dialog.

The default should be that labels should contain enough information (enclosing package, enclosing container, ...) to avoid ever showing two identical-looking items to the user. Open Type's additional menu item "Show Container for Duplicates" should only always add full labels in cases where partial labels would in principle be enough to distinguish items.

Unfortunately, I see no way for us to implement this with current API. The problem is that we can only ask FilteredItemsSelectionDialog#isDuplicateElement(..), but we have no way to get our hand on the other duplicate elements to do the necessary comparisons (see TypeInfoViewer.TypeInfoLabelProvider#getText(last, current, next)) for the original implementation.

As a workaround for now, I've enabled "Show Container for Duplicates" permanently and removed the action from the Open Type menu (bug 184693).
Comment 1 Krzysztof Michalski CLA 2007-04-30 13:07:02 EDT
You can do it by implement getElementName(Object item). This method is using to mark elements as duplicate and during camelCase sorting in matchesRawNamePattern(Object item). It should resolve yours problem. 
Comment 2 Markus Keller CLA 2007-04-30 13:24:58 EDT
But as I said, we need to know the *other* duplicates. Otherwise we cannot decide if e.g. java.util.List needs to be rendered with the container, because we don't know whether it would be unique if rendered without.
Comment 3 Szymon Brandys CLA 2008-05-30 04:30:43 EDT
Krzysztof left the team some time ago. I'm removing the target milestone.
Comment 4 Szymon Brandys CLA 2008-05-30 11:28:20 EDT
Reassigning to Susan.
Comment 5 Susan McCourt CLA 2009-07-09 17:19:28 EDT
As per http://wiki.eclipse.org/Platform_UI/Bug_Triage_Change_2009
Comment 6 Eclipse Webmaster CLA 2019-09-06 16:07:52 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
Comment 7 Eclipse Genie CLA 2022-01-30 19:05:54 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.