Comment 1 Markus Keller 2007-04-27 09:15:25 EDT

The first entry is due to two plug-ins using the same keybinding. The second
entry is a duplicate key binding definition in the same plug-in. So, they are
both justified.

I'm not sure if it is a good idea to log these all the time. In practice,
people will install plug-ins from different sources, and they may not have a
chance to get the conflicts fixed in a reasonable timeframe.

I think it would be more helpful if the keybindings page offered a quick way to
find (and resolve) conflicts.

If you really want to keep these messages, then you should
- format them with linebreaks and indentation, and
- subsume all these log entries under a common parent entry, such that the
Error Log view can fold them away.

Comment 2 Dani Megert 2007-04-27 09:37:16 EDT

I got some more (different ones):

!ENTRY org.eclipse.jface 2 0 2007-04-27 12:01:45.729
!MESSAGE A conflict occurred for CTRL+W: [Binding(CTRL+W,ParameterizedCommand(Command(org.eclipse.help.ui.closeTray,Close User Assistance Tray,Close the user assistance tray containing context help information and cheat sheets.,Category(org.eclipse.ui.category.help,Help,null,true),org.eclipse.help.ui.internal.CloseHelpTrayHandler,null,null,true),null),org.eclipse.ui.defaultAcceleratorConfiguration,org.eclipse.ui.contexts.dialog,null,null,system), Binding(CTRL+W,ParameterizedCommand(Command(org.eclipse.ui.file.close,Close,Close the active editor,Category(org.eclipse.ui.category.file,File,null,true),org.eclipse.ui.internal.CloseEditorHandler@332b9a,null,null,true),null),org.eclipse.ui.defaultAcceleratorConfiguration,org.eclipse.ui.contexts.window,null,null,system)]

!ENTRY org.eclipse.jface 2 0 2007-04-27 12:01:45.729
!MESSAGE A conflict occurred for CTRL+F4: [Binding(CTRL+F4,ParameterizedCommand(Command(org.eclipse.help.ui.closeTray,Close User Assistance Tray,Close the user assistance tray containing context help information and cheat sheets.,Category(org.eclipse.ui.category.help,Help,null,true),org.eclipse.help.ui.internal.CloseHelpTrayHandler,null,null,true),null),org.eclipse.ui.defaultAcceleratorConfiguration,org.eclipse.ui.contexts.dialog,null,null,system), Binding(CTRL+F4,ParameterizedCommand(Command(org.eclipse.ui.file.close,Close,Close the active editor,Category(org.eclipse.ui.category.file,File,null,true),org.eclipse.ui.internal.CloseEditorHandler@332b9a,null,null,true),null),org.eclipse.ui.defaultAcceleratorConfiguration,org.eclipse.ui.contexts.window,null,null,system)]

Comment 3 Markus Keller 2007-04-27 12:19:11 EDT

*** Bug 184467 has been marked as a duplicate of this bug. ***

Comment 4 Paul Webster 2007-04-27 14:48:35 EDT

I updated the handler activation conflict as well:
!ENTRY org.eclipse.jface 2 0 2007-04-27 14:07:20.849
!MESSAGE Keybinding conflicts occurred.  They may interfere with normal accelerator operation.
!SUBENTRY 1 org.eclipse.jface 2 0 2007-04-27 14:07:20.849
!MESSAGE A conflict occurred for F11:
Binding(F11,
	ParameterizedCommand(Command(org.eclipse.debug.ui.commands.DebugLast,Debug Last Launched,
		Debug the last launch in debug mode,
		Category(org.eclipse.debug.ui.category.run,Run/Debug,Run/Debug command category,true),
		null,
		null,null,true),null),
	org.eclipse.ui.defaultAcceleratorConfiguration,
	org.eclipse.ui.contexts.window,null,null,system)
Binding(F11,
	ParameterizedCommand(Command(org.eclipse.jdt.ui.edit.text.java.add.javadoc.comment,Add Javadoc Comment,
		Add a Javadoc comment stub to the member element,
		Category(org.eclipse.jdt.ui.category.source,Source,Java Source Actions,true),
		LegacyHandlerWrapper(ActionHandler(action=org.eclipse.jdt.ui.actions.AddJavaDocStubAction@1e3f34c)),
		null,null,true),null),
	org.eclipse.ui.defaultAcceleratorConfiguration,
	org.eclipse.ui.contexts.window,null,null,user)

I've opened bug 184502 to track comment #2

PW

Comment 5 Paul Webster 2007-05-01 16:55:25 EDT

In I20070501-0010
PW

Comment 6 Dani Megert 2007-05-02 04:40:46 EDT

Paul, the message is still pretty unreadable on WindowsXP when the .log file is opened in editors that only accept the official CRLF as line delimiter. Since writing a .log entry is like writing to a file you need to use the right line delimiter and can't just use '\n'. Simply replace your StringBuffer with a BufferedWriter:
	StringWriter sw= new StringWriter();
	BufferedWriter bw= new BufferedWriter(sw);
	bw.write(someString);
	bw.newline();
	bw.write(someOtherString);
	bw.newline();
	...
	bw.flush();
	sw.toString;

Do you want a new bug for this or should I reopen this one?

Comment 7 Paul Webster 2007-05-02 10:38:46 EDT

Released to HEAD
PW

Comment 8 Paul Webster 2007-05-02 10:39:22 EDT

It will be included today when UI re-submits
PW

Comment 9 Dani Megert 2007-05-03 03:06:53 EDT

Verified using I20070503-0010.

Comment 10 Markus Keller 2007-05-04 07:02:30 EDT

(In reply to comment #1)
I've opened bug 185523 for logging all the time and bug 185518 for showing conflicts on the Keys pref page.