Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 184071 - Cross tab - data binding enhancement for aggregateOn field
Summary: Cross tab - data binding enhancement for aggregateOn field
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: BIRT (show other bugs)
Version: 2.2.0   Edit
Hardware: PC All
: P2 enhancement (vote)
Target Milestone: 2.2.0 RC2   Edit
Assignee: Frank Zhang CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 184070 186076 187201 188224 188816 188834
Blocks:
  Show dependency tree
 
Reported: 2007-04-25 13:45 EDT by Rima Kanguri CLA
Modified: 2007-05-31 12:47 EDT (History)
2 users (show)

See Also:


Attachments
suggested changes to filter and sort dialog (102.09 KB, application/pdf)
2007-04-30 17:21 EDT, Aashima Goel CLA
no flags Details
Updated sort and filter UI (144.33 KB, application/pdf)
2007-05-03 00:37 EDT, Rima Kanguri CLA
no flags Details
xTab Filter and Sort dialog changes. (161.65 KB, application/pdf)
2007-05-21 19:02 EDT, Aashima Goel CLA
no flags Details
changes in showing warning when list cannot be populated for filter expression (177.47 KB, application/pdf)
2007-05-23 17:59 EDT, Aashima Goel CLA
no flags Details
Crosstab Preference Page (37.96 KB, image/jpeg)
2007-05-30 06:36 EDT, Frank Zhang CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rima Kanguri CLA 2007-04-25 13:45:25 EDT
Current behavior - 
In the data binding column we support the following fields = Name, dataType,
expression, aggregateOn, etc.
The aggregateOn field is set only for aggregation binding columns ( i.e binding
columns that refer to Total.Functions ) and other cases it is “N/A”

In cross-tab report item the similar concept has been applied. As of now the
aggregateOn field is only set for data binding that define an aggregation.
Based on discussion between Wenbin, Gary and me, the following has been agreed.


New behavior ( we need to support for BIRT 2.2 )
1)In cross tab, the AggregateOn will also be set for non aggregation fields
too.
Example
a) name= country, expr = level[ country ] , type=string,   aggregatOn={
“Location”, “country”} ( dimensionName, levelName)
b) name = state, expr=level[state], type=string, aggregateOn= { “Location”,
”state” } 
c) name = sales, expr = measures[“sales”],                   aggrgateOn=”” 

d) name = TotalSalesForState, expr= measure[“sales”], aggregateOn= {“location”,
“state”}, function = SUM



2)Adavantages – Will make the cross tab filter and sort UI easy. Also each
bound column is associated with a level. If the aggregateOn is empty, it means
the bound column is for the detail row.

a. Filter
i. User selects the level for which he wants to define filter, In the filter
condition we only list out the bound columns which have one of the aggregateOn
=  levelName

ii. User selects the level for which he wants 
Example if user specifies 
Filter on level = Country
b.       SORT
selects the level for which he wants to define sort, In the SORT key we list
out the bound columns which are defined for that level ( i.e which have
aggregateOn = “levelName” )

This will require following UI changes
1) Whenever UI adds a level and dimension, and adds bound column, it needs to make sure the aggregateOn field is set to the levelName. Please make sure all addBoundColumn calls set the aggregateOn field as agreed.

2) UI – To show the binding columns for that level in the SORT key and Filter key field list. 
[wenbin]: More specifically, the sort/filter key field list should show binding columns that has aggregateOn == the current level key.
Comment 1 Aashima Goel CLA 2007-04-30 17:21:42 EDT
Created attachment 65432 [details]
suggested changes to filter and sort dialog
Comment 2 Rima Kanguri CLA 2007-05-03 00:37:51 EDT
Created attachment 65729 [details]
Updated sort and filter UI
Comment 3 Rima Kanguri CLA 2007-05-10 18:47:14 EDT
This bug contains two changes
1) Enhancments to aggregateON field to set the correct value
2) Advanced filter and sort support.
Comment 4 Ivy Li CLA 2007-05-11 03:10:10 EDT
*** Bug 184070 has been marked as a duplicate of this bug. ***
Comment 5 Rima Kanguri CLA 2007-05-16 14:05:18 EDT
We no more need to set aggregateON field for non aggregation column bindings
DtE will provide the API 
- get the list of column binding available for sort and filter for a given level
Comment 6 Rima Kanguri CLA 2007-05-18 00:29:09 EDT
(In reply to comment #3)
> This bug contains two changes
> 1) Enhancments to aggregateON field to set the correct value
> 2) Advanced filter and sort support.
> 

We dont need to make the (1) change mentioned above.
Comment 7 Chen Chao CLA 2007-05-21 05:34:34 EDT
DTE will support some API about memeber value. And the other APIs is avaliable.
Comment 8 Aashima Goel CLA 2007-05-21 19:02:03 EDT
Created attachment 68032 [details]
xTab Filter and Sort dialog changes.

Based on the comments the dialogs have been revised. 
In addition, window-preferences will have 'Filter limit' category under report design to change the default values.
Comment 9 Aashima Goel CLA 2007-05-21 19:13:17 EDT
Please make sure page # 7 in the PDF is the major change.
Comment 10 Rima Kanguri CLA 2007-05-21 19:46:18 EDT
Aashima has updated the UI to allow user set the Filter limit using Window Preference.
Comment 11 Frank Zhang CLA 2007-05-22 02:12:46 EDT
I shall do the coding soon, but we need DTE to provider another APIs about member value, Chao Chen will send DTE a bug to provider an APIs.
Comment 12 Aashima Goel CLA 2007-05-23 17:59:29 EDT
Created attachment 68470 [details]
changes in showing warning when list cannot be populated for filter expression

page 8 has been added to the PDF that shows a warning when user selects a measure or aggregation and values cannot be displayed in filter condition.
Comment 13 Frank Zhang CLA 2007-05-24 09:02:56 EDT
Fixed.
Comment 14 Frank Zhang CLA 2007-05-29 00:02:12 EDT
When user select member value list(see page 6 and page 8), it may return error list or throw an exception, that's because the APIs from DTE contain error. I've sent them a bug to resolve it. (Bug 189575)
Comment 15 Rima Kanguri CLA 2007-05-29 18:33:08 EDT
Its not complete yet, please refer to comments from Aashima
Comment 16 Aashima Goel CLA 2007-05-29 18:35:51 EDT
 I do not see Comment  #9 implemented. Having the filter limit in Windows-preferences is not fixed
Comment 17 Frank Zhang CLA 2007-05-29 22:09:19 EDT
Please see preference Report Design -> Crosstab, there's a page to set filter limit.
I only change the page name from "Filter Limit" to "Crosstab". That's because 
"Filter Limit" will confuse users, what does it mean?
What's you opionion ? If you still insist, I'll change it to "Filter Limit".
 
Comment 18 Frank Zhang CLA 2007-05-29 22:55:05 EDT
There're 2 relative bugs to this one.
Bug 189805: assigned to Model.
Bug 189807: assigned to DTE.
Comment 19 Frank Zhang CLA 2007-05-30 01:22:33 EDT
Another relative bug 189829, Lin will handle it.
Comment 20 Frank Zhang CLA 2007-05-30 06:36:37 EDT
Created attachment 69243 [details]
Crosstab Preference Page

The preference page in Comment  #16, it's not missing.
Comment 21 Frank Zhang CLA 2007-05-30 06:37:40 EDT
The attachment in comment #20 is the preference page. 
The difference between the page and spec is the page name, and the others keep the same.

Set to FIXED.
Comment 22 Aashima Goel CLA 2007-05-31 12:47:05 EDT
UI verified.
Build id: v20070531-0630