Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 183229 - Task Editor incoming changes message is confusing
Summary: Task Editor incoming changes message is confusing
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.0   Edit
Assignee: Robert Elves CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-19 13:36 EDT by Shawn Minto CLA
Modified: 2008-03-26 22:05 EDT (History)
1 user (show)

See Also:


Attachments
patch to make missing task data refresh work with hyperlinking (5.86 KB, patch)
2008-02-13 17:52 EST, Robert Elves CLA
no flags Details | Diff
mylyn/context/zip (25.17 KB, application/octet-stream)
2008-02-13 17:52 EST, Robert Elves CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Shawn Minto CLA 2007-04-19 13:36:22 EDT
When a task is open in the rich editor and it is synchronized and found to have changes, a warning icon and message is given to the user.  The message says "Task has incomming changes, synchronize to view".  It is expected that the user clicks the refresh button in the right hand corner of the editor, however this message seems to tell the user to synchronize the task, not the editor.  If a user does this, the editor is never refreshed until it is closed and reopened.  I think that the message should be changed to reflect that the editor needs to be refreshed, not the task, and direct the user to where the refresh button is, or hyperlink the message so that clicking it will refresh the editor.
Comment 1 Eugene Kuleshov CLA 2007-04-19 15:32:00 EDT
It makes sense to add a link to refresh right into the message. 

It also seems like current color used for this message (look like yellow-brown to me) is not very noticeable. Can we make that color configurable? I actually wonder if background for the whole header should change to the color used for changed attributes.
Comment 2 Eugene Kuleshov CLA 2007-04-20 07:37:09 EDT
See this blog about customizing form colors. http://eclipsenuggets.blogspot.com/2007/03/get-custom-colored-forms-in-4-easy.html
Comment 3 Mik Kersten CLA 2007-04-20 10:48:48 EDT
I believe that the warning color comes from fonts and is intended to be subtle.  I don't think that the header color should change unless the refresh happened automatically, because currently it is saying "stale" and that would say "changed".

Regarding the description, the idea was that we avoid adding both a notion of "Refresh" and "Synchronize" and just keep things simple by using the latter.  However, as indicated this is not quite working.  I wonder if we could do the following:
* Come up with a good color for "incoming/changed".
* Automatically refresh the contents of the editor, and change the header color ass suggested if that's happened, to indicate to the user that there is new content since the last opened the editor, but to avoid having them repeatedly click the button.

Comment 4 Robert Elves CLA 2007-05-04 20:50:58 EDT
 (In reply to comment #3)
> * Automatically refresh the contents of the editor, and change the header color
> ass suggested if that's happened, to indicate to the user that there is new
> content since the last opened the editor, but to avoid having them repeatedly
> click the button.

When would the task get marked as read? If the editor updates but the task keeps the incoming status this could be confusing.  If we update the editor marking the task as read (no incoming arrow) but the editor was never actually revealed and just closed they will effectively missed incoming.  Perhaps a selection listener on the editor causing mark read if the select otherwise remains incoming?
Comment 5 Mik Kersten CLA 2007-05-04 22:09:04 EDT
Right, this could be too confusing, because the task would have to lose its incoming indicator as you suggest.  Or perhaps it could lose it when the editor first got focus?
Comment 6 Eugene Kuleshov CLA 2007-05-04 23:57:33 EDT
 (In reply to comment #5)
> Or perhaps it could lose it when the editor first got focus?

Pleeeeeease remove incoming indicator AFTER editor is closed.
Comment 7 Mik Kersten CLA 2007-05-07 15:36:00 EDT
 (In reply to comment #6)
> Pleeeeeease remove incoming indicator AFTER editor is closed.

Wouldn't that go against the UI idiom used by most email readers?
Comment 8 Eugene Kuleshov CLA 2007-05-07 16:40:53 EDT
(In reply to comment #7)
> Wouldn't that go against the UI idiom used by most email readers?

Most email readers actually allow you to set a timeout how long you have to look at email before it will be marked as read, more over, most of these editors don't use "show only unread" by default. So, I don't think your example is exactly fits with this use case. More over, it is actually completely opposite to how Mylar's own filtering works for Package Explorer, which unfilter things when editor is opened and filter them out when editor is closed.
Comment 9 Eugene Kuleshov CLA 2007-06-26 20:06:58 EDT
(In reply to comment #7)
> > Pleeeeeease remove incoming indicator AFTER editor is closed.
> Wouldn't that go against the UI idiom used by most email readers?

This is not really related to this bug summary, but I think interaction model in mail reader is different from Mylar because mail readers are using master/detail UI and email content is much less structured/complicated then task content. So, for them moving to next email mean it is been read. For Mylar you may open editor, then go into some other one without actually reading bug. On top of that, read issues disappear from the task list (and that is bad because we can't drag them nor call additional actions), which is also not the case for email readers.
Comment 10 Mik Kersten CLA 2008-02-12 12:41:46 EST
Let's get the failure case of this done (missing task data) for 2.3.
Comment 11 Robert Elves CLA 2008-02-13 17:52:37 EST
Created attachment 89693 [details]
patch to make missing task data refresh work with hyperlinking
Comment 12 Robert Elves CLA 2008-02-13 17:52:39 EST
Created attachment 89694 [details]
mylyn/context/zip
Comment 13 Robert Elves CLA 2008-02-21 21:45:56 EST
 (In reply to comment #10)
> Let's get the failure case of this done (missing task data) for 2.3.
Done. Deferring further improvements post 2.3
Comment 14 Steffen Pingel CLA 2008-02-21 22:55:32 EST
What is left to do here? Mik and I changed the message to "Task has incoming changes" and the message is a hyperlink now.
Comment 15 Eugene Kuleshov CLA 2008-02-21 23:23:52 EST
Until I forgot. If you submit some comments and get back "mid-air collision" error. "Incoming changes" message does not appear...
Comment 16 Robert Elves CLA 2008-03-26 22:05:00 EDT
Eugene, it would be great if you could create a new bug to address the mid-air collision bug you've raised.