Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 182771 - Web services runtime processing should be more fault tolerant
Summary: Web services runtime processing should be more fault tolerant
Status: CLOSED FIXED
Alias: None
Product: WTP Webservices
Classification: WebTools
Component: jst.ws (show other bugs)
Version: 1.5.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0.1   Edit
Assignee: Kathy Chan CLA
QA Contact: Chris Brealey CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-17 11:25 EDT by Kathy Chan CLA
Modified: 2008-07-16 20:05 EDT (History)
0 users

See Also:

Attachments
Patch (3.18 KB, patch)
2008-06-26 18:39 EDT, Kathy Chan CLA 		no flags Details | Diff
Patch (3.18 KB, patch)
2008-06-26 18:39 EDT, Kathy Chan CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kathy Chan CLA 2007-04-17 11:25:19 EDT 
Driver:  WTP 2.0 M6 + adopter product

When selecting Web Services -> Web service in a driver that has a Web services runtime that defined a <require-facet-version> for a facet version that does not exist, the following error is displayed even before the Web service wizard comes up:

WAB0234E An internal error occurred. Details: NLS missing message: facetVersionNotDefined in: org.eclipse.wst.common.project.facet.core.internal.FacetedProjectFrameworkImpl
    java.lang.IllegalArgumentException: NLS missing message: facetVersionNotDefined in: org.eclipse.wst.common.project.facet.core.internal.FacetedProjectFrameworkImpl
    at org.eclipse.wst.common.project.facet.core.internal.util.Versionable.getVersion(Versionable.java:80)
    at org.eclipse.wst.common.project.facet.core.internal.ProjectFacet.getVersion(ProjectFacet.java:1)
    at org.eclipse.jst.ws.internal.consumption.ui.wsrt.ServiceRuntimeDescriptor.getRequiredFacetVersions(ServiceRuntimeDescriptor.java:84)
    at org.eclipse.jst.ws.internal.consumption.ui.wsrt.FacetMatchCache.getTemplatesForServiceRuntime(FacetMatchCache.java:438)
    at org.eclipse.jst.ws.internal.consumption.ui.wsrt.WebServiceRuntimeExtensionUtils2.getAllServiceProjectTypes(WebServiceRuntimeExtensionUtils2.java:132)
    at org.eclipse.jst.ws.internal.consumption.ui.preferences.ProjectTopologyDefaults.getServiceTypes(ProjectTopologyDefaults.java:24)
    at org.eclipse.jst.ws.internal.consumption.ui.preferences.PersistentProjectTopologyContext.load(PersistentProjectTopologyContext.java:35)
    at org.eclipse.jst.ws.internal.consumption.ui.plugin.WebServiceConsumptionUIPlugin.getProjectTopologyContext(WebServiceConsumptionUIPlugin.java:93)
    at org.eclipse.jst.ws.internal.consumption.ui.widgets.runtime.ClientRuntimeSelectionWidgetDefaultingCommand.defaultClientSideFromServiceSide(ClientRuntimeSelectionWidgetDefaultingCommand.java:1296)
    at org.eclipse.jst.ws.internal.creation.ui.widgets.runtime.ServerRuntimeSelectionWidgetDefaultingCommand.defaultClientSide(ServerRuntimeSelectionWidgetDefaultingCommand.java:210)
    at org.eclipse.jst.ws.internal.creation.ui.widgets.runtime.ServerRuntimeSelectionWidgetDefaultingCommand.execute(ServerRuntimeSelectionWidgetDefaultingCommand.java:189)

Note that the problem does not show up the second time the Web services wizard is invoked because FacetMatchCache is only called once.

The Web services runtime extension code should be more fault tolerant rather than issueing an error.
Comment 1 Kathy Chan CLA 2007-05-04 10:10:37 EDT 
When a Web services runtime is incorrectly defined, it also has the following symptom in the preference page:

When opening the Web Services Project Topology preference page, there is an error message:

The currently displayed page contains invalid values (no details).

The controls on the page are blank afterwards.
Comment 2 Kathy Chan CLA 2008-05-22 14:34:54 EDT 
Deferring to WTP 3.0.1.
Comment 3 Kathy Chan CLA 2008-06-26 18:39:07 EDT 
Created attachment 105960 [details]
Patch
Comment 4 Kathy Chan CLA 2008-06-26 18:39:35 EDT 
Patch committed and released to WTP 3.0.1 as v200806262217.
Comment 5 Kathy Chan CLA 2008-06-26 18:39:52 EDT 
Created attachment 105961 [details]
Patch
Comment 6 Kathy Chan CLA 2008-07-16 20:05:03 EDT 
Verified and closing.