Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 182750 - Processing attach/detach commands while VM is not initialized
Summary: Processing attach/detach commands while VM is not initialized
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P1 critical (vote)
Target Milestone: ---   Edit
Assignee: Guru Nagarajan CLA
QA Contact:
URL:
Whiteboard: closed460
Keywords:
Depends on:
Blocks: 141540
  Show dependency tree
 
Reported: 2007-04-17 10:00 EDT by Viacheslav CLA
Modified: 2016-05-05 10:48 EDT (History)
3 users (show)

See Also:


Attachments
retry mechanism patch (10.58 KB, patch)
2007-05-04 06:12 EDT, Vitaly Provodin CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Viacheslav CLA 2007-04-17 10:00:20 EDT
In current agent implementation attach/detach commands (result of AC Start/Stop commands) received before VM initializing completion are silinly  ignored. It does not look like correct behavior. The commands should be processed correctly. There are two options:
1. The command can force profiler to apply attach/detach scenarios somehow.
2.The agent can return error command back to the workbench and a message may be displayed to the user or workbench can resend command latter.
Comment 1 Asaf Yaffe CLA 2007-04-18 10:07:27 EDT
Option 1 is not feasible. Attach/detach implies the need to redefine loaded classes (at least in the case of the CPU and Heap profilers). The JVMTI APIs for redefining classes cannot be used before the VM has initialized.

Another option to consider is for the JVMTI Agent to send a notification back to the client when the VM has initialized. The client can register for this notification, and enable the attach/detach UI buttons and menus only after receiving this notification.
Comment 2 jkubasta CLA 2007-04-19 19:14:58 EDT
Is this containable in 4.4?
Comment 3 Guru Nagarajan CLA 2007-05-02 10:11:28 EDT
This has to be closed in i3.
Comment 4 Vitaly Provodin CLA 2007-05-04 06:12:52 EDT
Created attachment 65895 [details]
retry mechanism patch

Guru,

Here is the patch for retry mechanism: When the client receives an error, it will not show a message to the user, it will silently wait for a while and try again. Try loop repeats 3-4 times and then bails out with an error message.
Could you please review it?
Comment 5 Guru Nagarajan CLA 2007-05-04 09:32:55 EDT
Patch applied.
Comment 6 Paul Slauenwhite CLA 2009-06-30 13:25:13 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.
Comment 7 Paul Slauenwhite CLA 2009-06-30 13:56:35 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.