182575 – [Site Editor] Editor stops updating platform filter after switching to site.xml

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 182575 - [Site Editor] Editor stops updating platform filter after switching to site.xml

Summary: [Site Editor] Editor stops updating platform filter after switching to site.xml

Status:	RESOLVED DUPLICATE of bug 140520

Alias:	None

Product:	PDE
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	3.3
Hardware:	PC Windows 2000

Importance:	P3 normal (vote)
Target Milestone:	---
Assignee:	Benjamin Cabé
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2007-04-16 11:52 EDT by Danail Nachev
Modified:	2008-04-30 18:17 EDT (History)
CC List:	2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Danail Nachev

2007-04-16 11:52:09 EDT

Build ID: I20070323-1616

Steps To Reproduce:
1. Create Update Site project
2. Add some random feature to it
3. Change Operating Systems: property
4. Switch to site.xml tab. The "os" property has been added to the feature tag.
5. Switch back and change the Operating Systems: property again
6. Switch to site.xml. The site.xml isn't updated.
7. Save the site.xml. It doesn't contain the change.

Expected results:
The property changes should be reflected immediately in the site.xml tab and saved to the file.

Actual results:
The property changes wasn't available neither in site.xml tab or in the saved file.

There is no problem if you don't switch to the site.xml tab.

Comment 1 Benjamin Cabé

2008-04-30 17:54:45 EDT

Please mark this bug as dependent of the well-known bug 140520.

Since the WorkspaceSiteModel isn't an IEditingModel, addTextEditOperation() is never called in this code in org.eclipse.pde.internal.ui.editor.context.InputContext:

if (provider instanceof IEditingModel) {
	if (((IEditingModel) provider).isDirty())
		addTextEditOperation(fEditOperations, e);
}

Comment 2 Chris Aniszczyk

2008-04-30 18:17:04 EDT

yap, the site model is not a smart model :(

Comment 3 Chris Aniszczyk

2008-04-30 18:17:18 EDT


*** This bug has been marked as a duplicate of bug 140520 ***