Community
Participate
Working Groups
If my working set has nothing contained within it, I should be allowed to delete it. Hitting 'Delete' prompts no confirmation dialog and right-clicking on it doesn't work since 'Delete' is greyed out. It is cumbersome to have to go and edit my working sets just for this. If it's completely empty, deleting it should be no loss, and prompting a confirmation dialog should suffice as a deterrent for misclicked deletions.
It's not clear what delete would do. Remove the working set from the package explorer or delete the working set? If we add delete support, we should also add it on non-empty working sets
*** Bug 186691 has been marked as a duplicate of this bug. ***
Quoting my own opinion from bug#186691 about what to do on this case: "Sometimes I download a bunch of projects from CVS (to make some tests, study some code, etc.) and put them on a temporary Java Working Set. After working on that, I'd like to be able to just press <DEL> on the working set on package explorer, and have the working set and the included projects deleted."
When deleting a working set we should ask whether to remove it only from the Package Explorer or also delete the working set. For now we do not want to allow to delete the resources inside the working set.
Created attachment 119510 [details] The delete button is now enabled for Working Sets when set as top level elements, which helps the user to either remove or hide the Working Set(s) from the PE without having to reconfigure everytime.
Hi Raksha, thanks for the patch. I committed it with the following minor changes: - added missed @since tags - fixed some Javadoc texts, e.g. "selection" where an object or list was passed NOTE: always end first Javadoc sentence with a '.' - RefactoringAvailabilityTester.isDeleteAvailable(IWorkingSet) not needed - RefactoringAvailabilityTester.getWorkingSets(Object[]) not needed - the two methods are not needed - the following test is enough: if (ReorgUtils.containsOnlyWorkingSets(Arrays.asList(objects))) return true; - fixes: if (!(workingSet.getName().equals(OthersWorkingSetUpdater.ID))) this is not good for two reasons: 1) should use getId() and not getName() 2) always use constant.equals(...) because this prevents form potential NPE Available in builds > N20081204-2000.
Verified in I20081209-0100.
