Comment 1 Scott Lewis 2007-05-21 14:07:36 EDT

Changing target milestone, as although valuable, does not effect API.

Comment 2 Scott Lewis 2007-07-22 20:52:23 EDT

Changing target milestone to 1.1.0.

Comment 3 Scott Lewis 2007-10-16 14:39:54 EDT

Setting target milestone to correspond with Equinox provisioning M4.

Comment 4 Scott Lewis 2007-12-06 02:50:37 EST

Added platform proxy support using the IProxyService for both the default filetransfer provider org.eclipse.ecf.provider.filetransfer, and the apache httpclient-based provider org.eclipse.ecf.provider.filetransfer.httpclient.

Comment 5 Scott Lewis 2007-12-20 15:11:06 EST

Reopening to deal with testing-discovered issues;

Hi Jan,

Jan S. Rellermeyer wrote:
> Hi, 
>
>   
>> As you can see, it only sets the proxy configuration if the Proxy.Type
>> is HTTP (also represent HTTPS).  But for SOCKS, this code won't be
>> executed (for httpclient), and so no proxy configuration will be set
>> up.
>>     
>
>
> I think it happens at AbstractRetrieveFileTransfer.setupProxy(). 

Yeah, I it's actually in AbstractRetrieveFileTransfer.setupProxies(). 

> The problem
> is that it takes the protocol scheme as a proxy type. In case of http:// it
> requests the HTTP proxy settings from the IProxyService and this returns
> null. Hence, no proxy object is set. 
>   

I'm fixing this logic now.

>   
>> But the question is...what is httpclient's support for SOCKs proxying?
>>     
>
> Since SOCKS proxies should be transparent, I assume, there is no particular
> support necessary.
> http://www.innovation.ch/java/HTTPClient/urlcon_vs_httpclient.html states
> that SOCKS 4 and 5 work with httpclient.
>   

So, then...I assume that the httpclient socks proxy setup should be exactly the same as for UrlConnection...i.e. System.property-based.  Seem correct?

Thanks,

Scott

Comment 6 Scott Lewis 2008-04-18 01:23:33 EDT

Issued identified in comment #5 dealt with so resolving.