Description Alexander Gurov 2007-04-06 04:00:59 EDT

The Subversive users reported to us a bug in result of which Subversive cannot
open XML files in his Repositories View (in WTP environment) with the "Unknown
content type" message.
I investigated the problem and found that the reason of the problem is
additional constraints in the
org.eclipse.wst.sse.ui.StructuredTextEditor.setDocumentProvider() method:

...........
else if (input instanceof IStorageEditorInput && !(input instanceof
IFileEditorInput) && !(input instanceof IPathEditorInput)) {
        setDocumentProvider(StorageModelProvider.getInstance());
}
...........

The Subversive editor input implements not only IStorageEditorInput but IPathEditorInput interface also because it is
required for opening files with external editors (for example Subversive allows you to view pictures with the external viewers or view MS Word Document content in the MS Word etc.).

From my point of view these additional constraints is unreasonable and can be
easily removed from the code. Could you please remove it or tell me the reason for these contstraints and propose another acceptable solution which can solve the problem?

P.S.
>org.eclipse.team.internal.ccvs.ui.RemoteFileEditorInput works fine
Why it works with CVS?
With CVS it works because CVS have no functionaly which allows users to view repository documents with external tools and CVS RepositoryFileEditorInput do not implements IPathEditorInput interface.

>IPathEditorInput is really meant for files on the local filesystem.
We exported files content into temporary files on the file system in order to reduce memory usage and allow users to view files content with external tools.

>I'll need more concrete details on what kind of editor input is being used
Our editor input implements IAdaptable, IWorkbenchAdapter, IStorageEditorInput and IPathEditorInput interfaces.