181060 – [Contributions] Closed view still held onto via Identifier (leak)

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 181060 - [Contributions] Closed view still held onto via Identifier (leak)

Summary: [Contributions] Closed view still held onto via Identifier (leak)

Status:	RESOLVED DUPLICATE of bug 174908

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	3.3
Hardware:	PC Windows XP

Importance:	P3 normal (vote)
Target Milestone:	---
Assignee:	Paul Webster
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2007-04-04 16:42 EDT by Nick Edgar
Modified:	2007-04-24 07:52 EDT (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Nick Edgar

2007-04-04 16:42:36 EDT

3.3 M5

Doing a leak check on our views, I found one of our views still being held onto (after it was closed) via an Identifier.  Although the MutableActivityManager references the Identifier via a WeakHashMap, the ProxyActivityManager can reference the same Identifier via a strong reference.

It's easier to show you in the profiler than to make sense of an attached profile.

Comment 1 Nick Edgar

2007-04-04 16:44:05 EDT

To clarify: the reference chain between the view and the Identifier's goes through several ViewPluginAction and ObjectPluginAction instances.

Comment 2 Nick Edgar

2007-04-04 16:46:33 EDT

Also note that I had activated another view before taking the snapshot, so I don't think this is a dup of the other recent leak bug I filed.

Comment 3 Nick Edgar

2007-04-05 09:47:41 EDT

Paul, is this a dup of bug 174908?

Comment 4 Paul Webster

2007-04-05 09:53:47 EDT

(In reply to comment #3)
> Paul, is this a dup of bug 174908?

I suspect that it is (I was going to check your data first).  In M5 you could leak a part by using a context menu submenu or by simply by popping up a context menu and closing a part.

We fixed both of those, but recently.  The ViewPluginActions shouldn't be a problem (they were always disposed), and I'm pretty sure I've fixed the ObjectPluginAction (which were being leaked along with the PluginActionContributionItems.

PW

Comment 5 Nick Edgar

2007-04-05 10:21:15 EDT

Is the fix in the last I-build?  If so, I can test the fix out.  I was definitely seeing Identifier -> ViewPluginAction -> view in the ref graph.

Comment 6 Paul Webster

2007-04-05 10:27:25 EDT

Yes, the fix would be in I20070403
PW

Comment 7 Paul Webster

2007-04-24 07:52:46 EDT


*** This bug has been marked as a duplicate of bug 174908 ***