Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 179813 - Usage Summary editor improvements
Summary: Usage Summary editor improvements
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: meghan CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-28 14:22 EDT by Eugene Kuleshov CLA
Modified: 2007-05-18 02:25 EDT (History)
0 users

See Also:


Attachments
removes the scrollbars from the View and Perspective usage sections (41.38 KB, patch)
2007-05-11 18:43 EDT, meghan CLA
no flags Details | Diff
mylar/context/zip (4.00 KB, application/octet-stream)
2007-05-11 18:43 EDT, meghan CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Kuleshov CLA 2007-03-28 14:22:33 EDT
Usage Summary editor is not very usable right now.

First of all it is using fixed height and have two scroll panels and huge table with scroller. I think the whole editor should be on a scrollable panel (similarly to the task editor, which has single scroller), so perspective and view usage sections won't have scrollers.

Usage details table may use some filtering. I.e. allow to specify a pattern or prefix to filter out by key.

It may also make sense to move actions from the bottom into the fancy bar at the top of the editor.

Maybe instead of View File action there should be a separate editor tab that would use standard Eclipse text editor to show the changes. This way the same Usage Editor can be reused for opening arbitrary usage xmls.
Comment 1 Mik Kersten CLA 2007-03-28 21:53:20 EDT
 (In reply to comment #0)
> First of all it is using fixed height and have two scroll panels and huge table
> with scroller. I think the whole editor should be on a scrollable panel
> (similarly to the task editor, which has single scroller), so perspective and
> view usage sections won't have scrollers.

+1

> Usage details table may use some filtering. I.e. allow to specify a pattern or
> prefix to filter out by key.

This would be best as a separate enhancement request.

> It may also make sense to move actions from the bottom into the fancy bar at the
> top of the editor.

-1  We tried that and consistency with the task editor seems better for now.

> Maybe instead of View File action there should be a separate editor tab that
> would use standard Eclipse text editor to show the changes. This way the same
> Usage Editor can be reused for opening arbitrary usage xmls.

We tried that but Eclipse editor blows up when viewing large files because it puts them in memory.  So if the file is larger than xMB we have to force use of the System editor.
Comment 2 Eugene Kuleshov CLA 2007-03-28 22:15:23 EDT
(In reply to comment #1)
> > It may also make sense to move actions from the bottom into the fancy bar at the
> > top of the editor.
> 
> -1  We tried that and consistency with the task editor seems better for now.

You know that I never liked those action buttons in the Task Editor either. :-)

> > Maybe instead of View File action there should be a separate editor tab that
> > would use standard Eclipse text editor to show the changes. This way the same
> > Usage Editor can be reused for opening arbitrary usage xmls.
> 
> We tried that but Eclipse editor blows up when viewing large files because it
> puts them in memory.  So if the file is larger than xMB we have to force use of
> the System editor.

The problem is that system editor don't work either. The .xml file isn't really well formed XML so you can't open it in MSIE, which is default for XML, neither in Notepad.

The Eclipse text editor surprised me. I would expect that it won't load the whole thing...
Comment 3 meghan CLA 2007-05-11 18:43:07 EDT
Created attachment 66950 [details]
removes the scrollbars from the View and Perspective usage sections

This patch removes the scrollbars from the View and Perspective usage sections.  I couldn't figure out how to remove the scrollbars from the Browser widget so I changed it to a Text widget and added a new method getPlainTextReport() to IUsageCollector.

I don't think the attached context is very useful because my computer crashed twice while I was working on this bug and seemed to lose the context.
Comment 4 meghan CLA 2007-05-11 18:43:10 EDT
Created attachment 66951 [details]
mylar/context/zip
Comment 5 Mik Kersten CLA 2007-05-14 13:01:09 EDT
Great stuff Meghan, it looks much better now.  
Comment 6 Mik Kersten CLA 2007-05-18 02:25:09 EDT
Additional improvement requests should go on new bug reports.

Fyi, I added a new banner icon that looks consistent with the UI Usage Report icon.