Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 179121 - JDIModelPresentation does not allow spaces in variable names
Summary: JDIModelPresentation does not allow spaces in variable names
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 3.3 M7   Edit
Assignee: Darin Wright CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 178329
  Show dependency tree
 
Reported: 2007-03-23 16:25 EDT by Curtis Windatt CLA
Modified: 2007-03-29 14:49 EDT (History)
0 users

See Also:

Attachments
Patch (1.30 KB, patch)
2007-03-28 15:02 EDT, Curtis Windatt CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis Windatt CLA 2007-03-23 16:25:59 EDT 
Build ID: 3.3 M6

Steps To Reproduce:
In JDIModelPresentation.getVariableText(IJavaVariable var), the text is created by combining the variable name, a '=' character and the value text.  However, if the variable name has a space in it, all text before the last space character (' ') is removed from the label.

This is preventing the use of more descriptive names for inline references.  It is unclear why removing anything before the space is necessary.

More information:
Comment 1 Darin Wright CLA 2007-03-23 17:07:41 EDT 
We should remove this code... I cannot see a case where a variable name would have a space in it. As well, it looks like it accounts for a case where a variable name includes type information and we are trimming it off... but looking at our code I do not see this case.
Comment 2 Curtis Windatt CLA 2007-03-28 15:02:35 EDT 
Created attachment 62273 [details]
Patch

Code no longer cares about spaces in the text.
Comment 3 Curtis Windatt CLA 2007-03-28 15:05:07 EDT 
Darin please review
Comment 4 Darin Wright CLA 2007-03-29 14:49:35 EDT 
Applied patch.
Comment 5 Darin Wright CLA 2007-03-29 14:49:45 EDT 
Verified.