Community
Participate
Working Groups
A number of bugs have been found affecting the 'all instances' and 'all references' features. As most of the bugs/issues are related, they will be coalesced into this bug and fixed at the same time. Issues: - Global actions and key bindings must be improved - The style between all instances and references popups should be similar and have similar functionality. - The user must be informed if the displayed instances/references are being limited by preference settings. - Other Miscellaneous problems
Created attachment 61881 [details] Work in progress Work in progress Complete: - All references popup action now uses an inspect expression and the inspect popup dialog. This makes things look a lot more consistent (now both instances and references share the same size and look as inspect). In addition, the references now have proper icons and the expression can be moved to the expression view. - The labels used have been changed to be more consistent. The inspect popup states 'all references for foo' and 'all instances for foo'. The individual entries are treated as array entries '[x]'. More detailed names are not possible currently as they will show up incorrectly if columns turned off, see bug 178329 and bug 179121. - To inform the user that the number of instances/references shown is being limited by preferences set on the Heap Walking preference page, the actions request one more than the user specified max. If more than the user specified max is returned, the labels and detail pane are updated with '+' signs and an additional variable is added to the bottom of the list offering an explanation. - A global action was created for all instances and all references. Key binding was fixed for all instances. - The actions and variables were refactored to reduce code duplication and fix small bugs discovered. Todo: - Removing obsolete NLSed strings and NLSing new ones (assuming new label changes kept). - Determine what key bindings to use, All Instances has been given Ctrl-Shift-N, but this binding does not work in variables view and the anchor is incorrect in the outline view. The all reference action has no key binding because it is only available in the variables view (where the key bindings aren't working). - Testing of the actions (specifically the global actions) to ensure they work correctly in all circumstances.
*** Bug 178436 has been marked as a duplicate of this bug. ***
*** Bug 176855 has been marked as a duplicate of this bug. ***
*** Bug 176003 has been marked as a duplicate of this bug. ***
*** Bug 175705 has been marked as a duplicate of this bug. ***
Created attachment 62296 [details] Patch Possible fix. The patch depends on the fix for bug 179121, because this patch changes the name for inline references to "References for <name>". Everything appears to be working, but some discussion is needed in regards to the following two issues: 1) The global actions and key bindings are still not consistantly working in the variables view. Plus the anchor keeps on changing when using the key bindings. 2) The names of individual references follow an array style naming convention [0], [1], ... [n]. This naming convention makes it difficult to search for a specific reference (or keep track of it while stepping).
Complete, changes made to HEAD Significant changes to org.eclipse.jdt.debug and org.eclipse.jdt.debug.ui
Darin, please verify
*** Bug 178329 has been marked as a duplicate of this bug. ***
Verified.
