Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 179008 - Log adapter filter not working consistently
Summary: Log adapter filter not working consistently
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP.monitoring (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P1 major (vote)
Target Milestone: ---   Edit
Assignee: Alex Nan CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-23 09:47 EDT by Jeff Calcaterra CLA
Modified: 2010-06-03 15:08 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Calcaterra CLA 2007-03-23 09:47:14 EDT 
Build ID: i5

Steps To Reproduce:
1.  Open Log Import dialog.  Click Add...
2.  Type a string into the Filters text box.

Users in testing expected to be able to type WebSphere and get all the WebSphere adapters, but WebSphere did not show up because the adapter name was "IBM WebSphere".  Given that we cannot control the naming, it makes more sense to search the entire string.

This is an important function given the number of adapters, but the issue above makes it significantly less useful.
Comment 1 Eugene Chan CLA 2007-03-23 10:45:40 EDT 
IBM Adapters are not shipped in TPTP product. Please track defect with product that packages IBM Adapters.
Comment 2 Eugene Chan CLA 2007-03-23 10:50:28 EDT 
I misunderstood the problem.
Comment 3 Malcom Zung CLA 2007-03-23 10:55:45 EDT 
I tested this on the I5 RCP and typed in "Web".  All the WebSphere adapters appeared in the list.  It does search the whole string.
Comment 4 Eugene Chan CLA 2007-03-23 10:56:31 EDT 
(In reply to comment #3)
> I tested this on the I5 RCP and typed in "Web".  All the WebSphere adapters
> appeared in the list.  It does search the whole string.
> 

Verified with Malcom that the filter works as expected.
Comment 5 Jeff Calcaterra CLA 2007-03-23 11:23:52 EDT 
We are both right.  The test does work, but only when "Show categories" is not selected.  

When "Show categories" is selected, "web" does not bring up "WebSphere, it only brings up "BEA".  This says that it is not searching same fields in both cases, which was the expected behavior.  I am not sure what it is searching in this case, since BEA does not have web in the title.

The expected behavior would be to get the same results whether or not the user has "Show Categories" selected or not (Obviously, they should be organized in categories, if it is selected though).  This would mean that the filter should search two things:
1.  The category text
2.  The Adapter name text.

Maybe there are some other fields that are relevant to search as well.
Comment 6 Malcom Zung CLA 2007-03-23 11:37:16 EDT 
Show categories is not working in my driver so I'm not able to test it myself.  However, if what Jeff is describing is true, I agree with him that it should be fixed.
Comment 7 Eugene Chan CLA 2007-03-23 11:43:46 EDT 
Thanks Malcom for verifying the problem.
Target to be fixed in i3.
Alex, is there any existing defect for the show category bug?
Comment 8 Alex Nan CLA 2007-03-23 14:30:38 EDT 
This function was working in TPTP4.2, so this seems to be a regression introduced recently. I have the feeling that it is related to https://bugs.eclipse.org/bugs/show_bug.cgi?id=153758. Will investigate.
Comment 9 Jeff Calcaterra CLA 2007-03-23 16:00:14 EDT 
Changed name since the original title no longer reflects the issue.
Comment 10 Dave Smith CLA 2007-03-27 10:39:51 EDT 
Increasing priority as this should be fixed in 4.4.
Comment 11 Alex Nan CLA 2007-04-12 20:28:38 EDT 
Fixed.
Comment 12 Jeff Calcaterra CLA 2007-05-14 09:27:10 EDT 
Verified with LTA-RCP build from 5-11