Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 178884 - [JarProcessor] problem when skipping signing nested jars
Summary: [JarProcessor] problem when skipping signing nested jars
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Update (deprecated - use Eclipse>Equinox>p2) (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 critical (vote)
Target Milestone: 3.3 M7   Edit
Assignee: Andrew Niefer CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 178886 179270
  Show dependency tree
 
Reported: 2007-03-22 16:02 EDT by Andrew Niefer CLA
Modified: 2007-04-11 18:18 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Niefer CLA 2007-03-22 16:02:12 EDT
Extracted from bug 175284
All of the repack (pack200 -r), unpack200, and jarsigner tools leave their results in slightly different formats with respect to the compression of the resulting jar (mostly around whether crc & size information goes before or after a record entry).  This may depend on the OS & VM used.  Because of this, when nesting jars inside of something that is being signed, the jarprocessor performs a "normalization" step on the nested jars to ensure that they are always the same.

It appears that by skipping the signing on the nested jars, we are also
skipping one of the normalization steps resulting in nested jars whose contents
are identical, but where the jars themselves have different bytes because of
the crc & size info moving around.
Comment 1 Dejan Glozic CLA 2007-04-11 09:41:58 EDT
Raising the importance - Welcome needs this so that we can test layering (installing Platform, then JDT and PDE).
Comment 2 Andrew Niefer CLA 2007-04-11 18:18:58 EDT
Fixed in head.  This affects the jarprocessor.jar that is used to do the conditioning, signing and packing.

I tested with pde.build excluding the nested pdebuild-ant.jar from signing.  I did  condition/sign, pack, unpack, verify on windows and linux.
I also did condition/sign, pack on linux, unpack and verify on windows.