Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 178197 - [Min/Max] View activated out of minimized view group always horizontal / setting ignored
Summary: [Min/Max] View activated out of minimized view group always horizontal / sett...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M7   Edit
Assignee: Eric Moffatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 153957
  Show dependency tree
 
Reported: 2007-03-20 04:35 EDT by Dani Megert CLA
Modified: 2007-05-01 14:37 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2007-03-20 04:35:11 EDT
I20070320-0010.

1. minimize a view group with a vertically outlined view
2. in the minimized view group click on one of the views
   ==> it gets activated
3. in the view tab change the 'Orientation'
   ==> nothing happens - it is always horizontal
Comment 1 Eric Moffatt CLA 2007-03-27 16:33:37 EDT
Daniel, the orientation of the views in a minimized stack is that of the stack (i.e. horizontal iff the stack is wider than it is tall when it's in the presentation); they aren't individually settable. This is based on the presumption that people will put a view in a stack that has the appropriate orientation...

My onclination here is to remove the 'Orientation' menu when the FastViewPane is showing a minimized view rather than to imlpement the behavior.

Comments ??
Comment 2 Dani Megert CLA 2007-03-28 03:03:48 EDT
>This is based on the
>presumption that people will put a view in a stack that has the appropriate
>orientation...
This is a wrong assumption, especially when users maximize an editor where each single view is placed into its own vertical stack. It will be very confusing for the user to see the view menu when it's a normal fast view and be able to select the orientation but not when it's a out of minimized stack. 

I can set a vertically shown view to be shown horizontally when it's a fast view (and the other way around), and this state is remembered. What is the rational to prevent me from doing this when it's a minimized stack? Especially, when the stack only contains a single view?

Maybe it is easier to understand with a use case:
1. have your dev workspace with many projects
2. open the Java Browsing perspective
3. open an editor and maximize it
4. now click on the Projects view (in a minimized stack on the left)
==> it opens horizontally but I would really like to see it vertically as there are many projects in it.
Comment 3 Eric Moffatt CLA 2007-03-28 10:10:31 EDT
I see your test case and understand its implications...there -will- be some mechanism allowing you to 'tune' the display of your view...I'm currently working on what it will be...;-).
Comment 4 Eric Moffatt CLA 2007-04-09 14:38:34 EDT
Daniel, I'm not sure if I will be able to do anything with this in 3.3. I certainly won't get to it in M7. Let me get my head above water and I'll take another go...
Comment 5 Eric Moffatt CLA 2007-04-26 13:07:11 EDT
For 3.3 the best we can do is to remove the 'Orientation' menu entry from the context menu in the FastViewPane (See bug 184088).

We use the stack's layout when it's in the main presentation to determine the orientation it uses when showing as a fast view. This is by design (to avoid confusing clients that aren't legacy FastView users).

I have a 'mock up' of something we can do post 3.3 but it's too late for this pass.

Marking as 'fixed'; Dani, feel free to open an enhancement request if you want but it won't be necessary since this is already on my 'hot list' for futures...

Comment 6 Eric Moffatt CLA 2007-04-26 13:07:47 EDT
Ooops, really marking as FIXED...
Comment 7 Eric Moffatt CLA 2007-05-01 14:37:12 EDT
Verified in I20070501-0010.