Community
Participate
Working Groups
Build ID: Ver 3.3 Steps To Reproduce: Build ID: Version 3.3 Steps To Reproduce: Note: Treat Caps Lock latin letters as BiDi (Hebrew/Arabic) letters. Also, this defect is relevant when eclipse is being run with -dir rtl. The defect is relevant to each window that perform the following operations :Open File,Import,Export,Browse...,Save As,New etc'. For instance we describe an Import files from Dir path which contain BIDI Dir names. 1.Run eclipse with -dir rtl flag. 2.Create a simple project in your workspace. 3.Go to "File -> Import... -> FileSystem" and Browse a path as suggested above. e.g: c:\ies\ABC\DEF\test.txt Actual Result: test.txt\DEF\ABC\c:\ies Expected Result:c:\ies\ABC\DEF\test.txt More information: More information: Even though the directionality of eclipse is RTL, the user would like to see the File path and names in LTR order,which is the natural order. Also those widget better have Left alignment
Dear developers. There is another issue we need to discuss regarding this defect. We divide it into two categories: 1. The one with less severity. When we run eclipse with -dir rtl and we choose the dir/file/arguments or any complex expression which involve the \,-,.,(,) special characters, we don't see it as we want too. e.g :Workspace Data. Go to Run..-> Run->Main Tab. We don't see the complex expression as we want in the "Location" text box: Actual Res: workspace_loc}/../runtime-New_configuration}$ Exp Res: ${workspace_loc}/../runtime-New_configuration BUT this can be fixed, by left-side Ctrl+shift keystrokes to change the alignment of the text box. So thats why this issue is less concerning. 2. This category is what we describe in the defect. In this case the orientation of the widget canot be changed by the user, because it's a READ ONLY widget. e.g: The file name display in the Package Explorer. e.g: The path as displayed in the Tool Tip Text component.
Changing the Severity to match to BiDi criteria
-dir rtl will not give text processing in a non bidi Locale. Do you have this issue with -nl iw?
(In reply to comment #3) > -dir rtl will not give text processing in a non bidi Locale. Do you have this > issue with -nl iw? This defect has been verified with eclipse-SDK-I20070430-1300 Stream Integratin Build. when i run the defect with -nl iw flag the defect still exist. See the attached image please.
Created attachment 65456 [details] Undesired order of File path in the text box.
I think this is the live text typing problem (does not go through text processor) PW
Created attachment 167658 [details] Patch v01 Using TextProcessor to process/deprocess the text
*** Bug 234632 has been marked as a duplicate of this bug. ***
*** Bug 392284 has been marked as a duplicate of this bug. ***
*** Bug 273926 has been marked as a duplicate of this bug. ***
Daniel, maybe Moshe (Moshe WAJNBERG <wajnberg@il.ibm.com>) can provide a patch. He did before for similar bugs. If not, you might want to see how he fixed similar bug 273728 and bug 404234.
Created attachment 235719 [details] Import wizard
Created attachment 235721 [details] Export wizard
Created attachment 235723 [details] Run as dialog The import and export wizards issue seems to be fixed, see 'Import and export wizards' attachments. However there is still the issue with the location field in the 'Run as...' dialog, see 'Run as dialog' attachment It was verified in the build: I20130918-2000 I'll investigate the location issue, Daniel
(In reply to Daniel Rolka from comment #14) > Created attachment 235723 [details] > Run as dialog > > The import and export wizards issue seems to be fixed, see 'Import and > export wizards' attachments. However there is still the issue with the > location field in the 'Run as...' dialog, see 'Run as dialog' attachment > > It was verified in the build: I20130918-2000 > > I'll investigate the location issue, > Daniel I've made quick investigation and it looks that the issue is connected to the 'bundleclass://org.eclipse.debug.ui/org.eclipse.debug.ui.WorkingDirectoryBlock' class that processes using the '${workspace_loc' pattern (for instance the setDefaultWorkingDir method) I'm going to reassign this bug to the JDT component, Daniel
(In reply to Daniel Rolka from comment #15) > (In reply to Daniel Rolka from comment #14) > > Created attachment 235723 [details] > > Run as dialog > > > > The import and export wizards issue seems to be fixed, see 'Import and > > export wizards' attachments. However there is still the issue with the > > location field in the 'Run as...' dialog, see 'Run as dialog' attachment > > > > It was verified in the build: I20130918-2000 > > Did you try to type into that field? Moving back to UI since this bug is about the import/export wizards. If that's fixed then we can close it. If there's still a bug in Debug, then a new bug must be opened (if there's none already).
Yes, typing in the 'From directory' and 'Into directory' fields in the import wizard works fine. So I will close the bug. For the issue reported in the comment 1 I've opened the new bug 418366 for JDT Daniel
Comment on attachment 167658 [details] Patch v01 For editable fields, org.eclipse.jface.util.BidiUtils is the only way to go. We don't use TextProcessor for that.
We need to apply the BiDi utils. PW
RTL support is still broken in the Import/Export wizards. Easiest way to see that on Windows is to append "\" at the end of the "From directory" (will be rendered on the left of the path). When I type Hebrew characters on Windows, then the path is also mangled. BidiUtils has no support for Combo at this time, since the SWT APIs are missing (bug 407927). In the import dialog, we could add processing for "Into folder" (since that's a Text), but not for the Combo (main request from comment 0). To enable support for the new Bidi stuff, add this to the command line: -bidi "on=y;textDir=rtl" To see which fields are Bidi-processed, set BidiUtils.DEBUG to true. Processed fields will get a colored background and a tooltip with the structured text type.
For the time being you can call org.eclipse.swt.widgets.Combo#setTextDirection(SWT.LEFT_TO_RIGHT) - which will enforce LTR base direction on combo (the API is supported on win32 only).
The issue presented by the 'Undesired order of File path in the text box' snapshot seems to be the SWT one. I've opened the Bug419143 to the SWT component for it. The partial fix for the 'Into folder' Text widget has been pushed to Gerrit: https://git.eclipse.org/r/#/c/17269/ To apply Bidi support for Combos used in the wizard we have to have the Bug407927 fixed Daniel
(In reply to Daniel Rolka from comment #22) > > The partial fix for the 'Into folder' Text widget has been pushed to Gerrit: > https://git.eclipse.org/r/#/c/17269/ I've released the fix for the Into folder: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=4d09b580d350e3fa5704595ed663809a5133a6da PW
Fixed with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=ea703d735ab0d9963f846ebb57087cef826b1a8e
