Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 177988 - Launch configurations marked dirty for no reason
Summary: Launch configurations marked dirty for no reason
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M6   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 184741 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-03-18 23:37 EDT by Wassim Melhem CLA
Modified: 2007-04-30 13:43 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wassim Melhem CLA 2007-03-18 23:37:08 EDT 
Build id: I20070313-1051

1. In the LCD, create any launch configuration that contains the Common and/or Environment tabs, e.g. Java Application, Eclipse Application

2. Switch to either of those tabs and do not make any changes.  Note how the Apply button is now enabled and the Revert button does nothing.
Comment 1 Darin Wright CLA 2007-03-19 10:47:42 EDT 
I can't make this happen with Java Applications. It appears to happen when I press the "Plug-ins" tab of the PDE configuration. Moving to PDE.
Comment 2 Darin Wright CLA 2007-03-19 10:49:35 EDT 
.. and it only happens on a brand new config

* create a new Eclipse Application config
* swith to the Plug-ins tab


> dirty
Comment 3 Darin Wright CLA 2007-03-19 10:54:50 EDT 
OK, taking it back...
Comment 4 Darin Wright CLA 2007-03-19 10:55:06 EDT 
this attribute is added:

org.eclipse.debug.core.appendEnvironmentVariables=true
Comment 5 Darin Wright CLA 2007-03-19 11:23:52 EDT 
Fixed in CommonTab and EvnrionmentTab. There were mismatches between setDefaults(...) and performApply(...).

* The CommonTab was setting ATTR_LAUNCH_IN_BACKGROUND to be true in setDefaults, but in performApply it removed the flag if it was the default value (i.e. true).
* The EnvironmentTab was setting ATTR_APPEND_ENVIRONMENT_VARIABLES to true or false (true if never touched) in performApply, but never set the corresponding default in setDefaults
Comment 6 Darin Wright CLA 2007-03-19 11:24:05 EDT 
Please verify, Mike.
Comment 7 Michael Rennie CLA 2007-03-19 12:07:05 EDT 
verified
Comment 8 Darin Wright CLA 2007-04-30 13:43:37 EDT 
*** Bug 184741 has been marked as a duplicate of this bug. ***