Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 177171 - [Help] Preserve pre-3.3 handling of invalid link_to's
Summary: [Help] Preserve pre-3.3 handling of invalid link_to's
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 3.3 M6   Edit
Assignee: Curtis d'Entremont CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 173882
  Show dependency tree
 
Reported: 2007-03-13 12:40 EDT by Alex Nan CLA
Modified: 2007-03-13 15:02 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Nan CLA 2007-03-13 12:40:47 EDT 
Build ID: I20070209-1006

Steps To Reproduce:
The following two RCP applications http://www.eclipse.org/downloads/download.php?file=/tptp/4.4.0/TPTP-4.4.0-200702211545/LogAnalyzer.win32.win32.x86-TPTP-4.4.0-200702211545.zip
and 
http://www.eclipse.org/downloads/download.php?file=/tptp/4.4.0/TPTP-4.4.0-200702211545/SymptomEditor.win32.win32.x86-TPTP-4.4.0-200702211545.zip
have currently broken help content.
We were using in 3.2.1 the following toc label declaration
<toc label="Determining problems in applications" filter="plugin=org.eclipse.tptp.platform.doc.user" link_to="../org.eclipse.tptp.platform.doc.user/platform_toc.xml#log_analysis">
with the intend to reuse the RCP documentation in the sdk version of TPTP.
In the RCP the toc would be displayed as a root toc.
In Eclipse 3.3 the link seems to be broken.
For backward compatiblity reasons it would be good if you could keep the same behaviour as in 3.2.1, that is in the RCP display the topic as a root topic and in the sdk hook it up at the specified anchor.

More information:
Comment 1 Curtis d'Entremont CLA 2007-03-13 14:56:35 EDT 
To summarize, if you try to link into something that doesn't exist, it should promote it to a root toc, rather than ignoring (and hiding) it.
Comment 2 Curtis d'Entremont CLA 2007-03-13 14:57:46 EDT 
Fixed, and tested with TPTP docs.
Comment 3 Alex Nan CLA 2007-03-13 15:02:04 EDT 
Yes, that's the idea. Note that there is a filter there telling you to link only if that plugin exists, if it doesn't then promote it to a root topic.
Thanks Curtis for handling this so quickly.