Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 177153 - Agent Controller fails to start up after crash due to shared memory error
Summary: Agent Controller fails to start up after crash due to shared memory error
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P1 normal (vote)
Target Milestone: ---   Edit
Assignee: Igor Alelekov CLA
QA Contact:
URL:
Whiteboard: closed460
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-13 10:58 EDT by Igor Alelekov CLA
Modified: 2016-05-05 10:52 EDT (History)
2 users (show)

See Also:

Attachments
ra patch (5.63 KB, patch)
2007-03-14 11:38 EDT, Igor Alelekov CLA 		no flags Details | Diff
transport patch (3.02 KB, patch)
2007-03-14 11:43 EDT, Igor Alelekov CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Igor Alelekov CLA 2007-03-13 10:58:07 EDT 
If Agent Controller crashes or is terminated with SIGKILL(9) signal, it leaves unclean shared memory blocks and another user can't lanch AC due to shared memory creation error.
Comment 1 Samson Wai CLA 2007-03-13 13:13:48 EDT 
Hi Igor. Please evaluate and change the sizing and target field if necessary. I am setting it to 4.4i2 for now.
Comment 2 Igor Alelekov CLA 2007-03-13 14:15:59 EDT 
Samson, patch is ready and I'll submit it tomorrow.
Comment 3 Igor Alelekov CLA 2007-03-14 11:38:11 EDT 
Created attachment 60813 [details]
ra patch
Comment 4 Igor Alelekov CLA 2007-03-14 11:43:34 EDT 
Created attachment 60814 [details]
transport patch

Samson, please review the patches.
Logically there are two improvements:
- detecting if existing shared memory block is unused and opening for read/write when got creation memory error
- adding function to close shared memory block (marking it to remove by OS when all users will be deatached)
Comment 5 Samson Wai CLA 2007-03-14 11:56:02 EDT 
Hi Igor. I looked at "RASharedMemory.def" and the last entry should be "ossRamboClose" instead, right?
Comment 6 Igor Alelekov CLA 2007-03-14 13:04:01 EDT 
Yes, sorry for misprint.
I havn't tested the patch on Windows yet.
I've tested the patch on Linux today. It resolves the shared memory problem. And I'm going to perform some additional testting tomorrow.
Comment 7 Igor Alelekov CLA 2007-03-16 04:05:01 EDT 
Resolving since Samson committed the patch
Comment 8 Paul Slauenwhite CLA 2009-06-30 09:58:18 EDT 
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since the originator of this enhancement/defect has an inactive Bugzilla account and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.