Community
Participate
Working Groups
When executing Bidi testing for some of our product components we noticed that when using the org.eclipse.jface.wizard.WizardPage class the background image in the top panel of the wizard dialog is not mirrored. When running in non-Bidi languages the image appears to fade towards the right and then stops at the edge of the pane, but in a bidi mode where it is shifted to the left side of the pane, it looks bad that is starts from the left and then just stops when it reaches the top of the pane. Please see attached image of bidi and non-bidi images. This can be recreated by creating a standard plugin project, selecting a custom plugin wizard, then click next and then finish. With this new project in your workspace, create a new run configuration and set a new Program Argument of "-nl ar" to launch with in Arabic. Once the new SDK instance is launched right click in the workspace and select new, then other, then Sample Wizards then Multi page editor file. The wizard that appears will show the same problem in bidi. This is considered a serious bidi problem for our product, settnig to Major.
Created attachment 60554 [details] Bidi Wizard picture
Alternative icons need to be supplied by the wizard suppliers in thier langiage packs. Is this an issue in any SDK wizards with the BIDI language packs installed?
Created attachment 61027 [details] jface jar with flipped images Tod, here is the jface jar with the flipped images. However, I still couldn't get the jface wizard to display the flipped banner image. Please check if jface has the $nl$ code to search the flipped images.
Reopening to investigate
JFaceResources initializeDefaultImages is not using the nl prefix.
This turns out to be more complicated that just adding a $nl$ prefix - we actually need to migrate our lookup to use the OSGI as we did in the workbench. We will address is in M7.
Please make sure to attach the 3.3 patch, and risk assesment for a 3.2.2 backport.
Fixed in build >200700403. We were not using the bundle based lookup at all in JFace so I moved TitleAreaDialog, Dialog and PreferenceDialog over to an OSGi compliant lookup. This required me to move the icons so I have written the code such that if the new icons are not found the old ones can be looked up. We were also not using the .png version of the preference dialog icon which has a transparent background by default - I have updated to use it. I will attach an updated version of Kits example that reflects the new paths (thanks very much Kit). I would typify this as a low risk change should someone want to patch 3.2.2. I will attach a patch for 3.3 but this will be out of date for 3.2.2 as there have been some intervening changes.
Created attachment 62788 [details] patch
Created attachment 62789 [details] JFace Bidi example updated with new paths
Created attachment 65398 [details] A wizard with no images for testing
Created attachment 65529 [details] Better test example
Verified in I20070501-0010
