Community
Participate
Working Groups
While going through the report engine code, I noticed that the method setupRenderOption is being called in RunTask.doRun method. setupRenderOption method is used to intialize the render options used to render the report. I understand this is not needed in RunTask flow as we are only running the report.
Created attachment 60498 [details] Patch to remove call to setupRenderOption method from RunTask.doRun method Attaching a patch 'run_task_patch_bugzilla_176874.txt' which removes call to setupRenderOption method from RunTask.doRun method. The patch is created with the latest codeline in HEAD. With the patch, I ran all the tests in org.eclipse.birt.report.engine.tests. Did not see any new failures/errors. I saw the following tests fail with/without my patch: 1) ParameterConverterTest.testDateFormat 2) PDFImageLMTest.testPdfChartLegend 3) ReportDocumentTest.testDesignStream Out of these, failure 1 seems to be locale specific. The failures in 2 and 3 are also reported in https://bugs.eclipse.org/bugs/show_bug.cgi?id=176673 I also saw two java.lang.OutOfMemoryError: Java heap space errors in EngineIRReaderTest.testV1 and EngineIRReaderTest.testV2. These occur with/without my patch. Please take a look at this patch. Thanks.
the render options contains IImageHandler/IEventHandler which are used by run task now.
Thanks for looking at the patch. I see that IHTMLImageHandler and IHTMLActionHandler are part of RenderOption which gets set in the setupRenderOption method. I understand these can be set as emitter config. Are these used by the emitter when writing the report document? I would appreciate if you can explain or point me where these options are used in run task.
remove the setupRenderOption() method. fixed.
Comment on attachment 60498 [details] Patch to remove call to setupRenderOption method from RunTask.doRun method per Ganymede IP log
