Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 176845 - [Min/Max] Restore from Editor-Area leaves View unrestored
Summary: [Min/Max] Restore from Editor-Area leaves View unrestored
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M7   Edit
Assignee: Eric Moffatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 153957
  Show dependency tree
 
Reported: 2007-03-09 12:58 EST by Benjamin Pasero CLA
Modified: 2007-05-01 14:27 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Pasero CLA 2007-03-09 12:58:19 EST
Eclipse: 3.3 M5
Presentation: 3.3

Doubleclick the package explorer to maximize it, while having some editors open. Then hit "Restore" from the Editor FVB and notice the package explorer still showing the "restore" button in his view, although it has been restored from by the editor area already.

Ben
Comment 1 Eric Moffatt CLA 2007-03-13 15:51:44 EDT
I'm fairly sure that this is fixed as of tomorrow's build but I'll check.

Can you clarify what the steps are, I'm a but confused by the current description...;-)
Comment 2 Benjamin Pasero CLA 2007-03-13 16:43:58 EDT
Sure:

1.) Have the Java perspective with just the package explorer on the left
2.) Open some java files
3.) Maximize the package explorer
4.) From the editor FVB select "Restore"

Actual results:
The editor is restored and the Package Explorer shows as normal, however the package explorer's view toolbar is still showing the "Restore" icon, although it should show the "Maximize" icon.
Comment 3 Eric Moffatt CLA 2007-03-18 17:06:47 EDT
Got it, any time there's more than one stack in the presentation no stack should show as 'maximized'...

Good one...
Comment 4 Eric Moffatt CLA 2007-03-30 09:53:01 EDT
Committed in >20070330. Now, restoring -any- stack from the trim will result in the currently maximized stack being restored.

NOTE: Currently we're leaving the Restore button visible and active. Conceptually, trim stacks that are in the trim due to a maximize operation shouldn't -have- a restore affordance (so that users can distinguish between these stacks and stacks that have been explicitly minimized (and therefore don't come back on un-maximize).

However, one of the more likely workflows is that a user will open a view as a fast view and decide that they would prefer to put it back (e.g. it overlays too much of the Editor Area). Without having the restore affordance on the trim stack they'd have to move the mouse across the entire window and click on the editor area's restore button...

This is still under review and may change if it appears to confuse too many users...
Comment 5 Eric Moffatt CLA 2007-05-01 14:27:40 EDT
Verified in I20070501-0010.