Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 175957 - Bring back the alt-shift-R keybinding for rename
Summary: Bring back the alt-shift-R keybinding for rename
Status: RESOLVED DUPLICATE of bug 181830
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: Other Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: JDT-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-28 18:49 EST by Stefan Xenos CLA
Modified: 2007-04-18 03:36 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Xenos CLA 2007-02-28 18:49:11 EST
Previously, alt-shift-R would open a dialog that let you rename the selected object. In Eclipse 3.3 M5, you need to press it twice (pressing it once opens some sort of popup - I tried various things, but could not figure out what the popup did).

Please bring back the old keybinding.
Comment 1 Dani Megert CLA 2007-03-01 02:09:33 EST
>I tried various things, but could not figure out what the popup did).
I suggest to read the N&N of M5 as a start ;-)
Comment 2 Stefan Xenos CLA 2007-03-01 03:42:06 EST
IMHO, we should not require that all users read the new & noteworthy in order to  use the UI. The fact that doing so is necessary is probably an indication that the UI is not intuitive enough.

Even if the UI were completely self-explanatory, it seems that a frequently-used action (rename) was moved to a two-keystroke command in order to give a rarely-used action (rename-within-file) a one-keystroke command.

Please reopen and fix.
Comment 3 Dani Megert CLA 2007-03-01 03:46:40 EST
It is stil the same i.e. 'Rename Refactoring' - just lightweight. If you don't like the lightweigt rename then simply disable it as outline in the N&N.
Comment 4 Stefan Xenos CLA 2007-03-20 20:50:36 EDT
> It is stil the same i.e. 'Rename Refactoring' - just lightweight. 

It does not appear equivalent. The rename refactoring changes all references in all files and will rename the compilation unit when renaming a java file, while the lightweight one only seems to change references in the current file.


> If you don't like the lightweigt rename then simply disable it as 
> outline in the N&N.

I did not file this bug because I wanted it for my personal use, I filed it because I believe this is the best behavior for all Eclipse users. The fact that a preference exists that allows me to change it is irrelevant unless the preference is on by default.
Comment 5 Dani Megert CLA 2007-03-21 03:18:22 EDT
>The rename refactoring changes all references in
>all files and will rename the compilation unit when renaming a java file, while
>the lightweight one only seems to change references in the current file.
Then take a better look. It does EXACTLY the same thing as when going through the dialog except that it doesn't open it. Ctrl+2,R is Rename in File as it was in 3.2.

I guess what might confuse you is a different JDT refactoring feature namely that the files no longer need to be saved and hence the other updated reference report errors unless you save your current file.
Comment 6 Dani Megert CLA 2007-03-21 04:52:50 EDT
BTW: if you found a way where it only updates the current file then please file a bug report against JDT UI.
Comment 7 Kevin McGuire CLA 2007-04-17 14:38:10 EDT
See also 181830 for a discussion on why it might be throwing people off.

Note: this isn't a preference issue (I like blue, you like green), its a usability issue with an introduction of a new workflow that is confusing some. 
Comment 8 Dani Megert CLA 2007-04-18 03:35:32 EDT
.
Comment 9 Dani Megert CLA 2007-04-18 03:36:20 EDT

*** This bug has been marked as a duplicate of bug 181830 ***