Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 175399 - [regression] The layout of test views/editors doesn't appear right
Summary: [regression] The layout of test views/editors doesn't appear right
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P1 normal (vote)
Target Milestone: ---   Edit
Assignee: Jerome Gout CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 74949
Blocks:
  Show dependency tree
 
Reported: 2007-02-23 19:00 EST by amehrega CLA
Modified: 2016-05-05 10:32 EDT (History)
3 users (show)

See Also:


Attachments
Screen capture. (135.36 KB, image/jpeg)
2007-03-02 10:09 EST, Paul Slauenwhite CLA
no flags Details
This is how it should be displayed. Used the 4.2.1.1 driver. (48.22 KB, image/gif)
2007-03-28 18:42 EDT, Navid Mehregani CLA
no flags Details
This is how it's currently displayed in the 4.4 driver. Note that this is the same test file I've opened (49.54 KB, image/gif)
2007-03-28 18:44 EDT, Navid Mehregani CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description amehrega CLA 2007-02-23 19:00:25 EST
- Checkout test-results/platform/org.eclipse.hyades.use.cases
- Open the file:  org.eclipse.hyades.use.cases\gui_results\Profiling_and_Logging\4.4-1-Windows_XP\Platform.UI.ProfilingPerspective.Launch.Part4.execution

Notice the long horizontal scroll under the overview page.
The text fields need to be wrapped.
Comment 1 Paul Slauenwhite CLA 2007-03-02 08:50:42 EST
Owner: Please triage and assign a target, sizing and priority.
Comment 2 Paul Slauenwhite CLA 2007-03-02 10:08:27 EST
Using the TPTP-4.4.0-200702211545 driver, this problem is visible (see screen capture).  Bianca, can you provide a sizing and if not containable in your 4.4 i2 schdule, plase assingn to me.  Thanks.
Comment 3 Paul Slauenwhite CLA 2007-03-02 10:09:08 EST
Created attachment 60164 [details]
Screen capture.
Comment 4 Paul Slauenwhite CLA 2007-03-19 11:08:24 EDT
Returning as WORKSFORME since each tabbed pane is scrollable in all TPTP Test tabbed editors and views. 
Comment 5 amehrega CLA 2007-03-19 11:34:05 EDT
Yes, but we shouldn't display the horizontal scroll bar if there is no need for one.  A previous release displayed the overview page much more cleanly than the latest build.

Whenever possible, we should condense a page's content so that it's viewable without scrolling.  I'll leave it up to you to decide if a fix is needed.
Comment 6 Paul Slauenwhite CLA 2007-03-19 12:36:06 EDT
Reopening to return as a duplicate.
Comment 7 Paul Slauenwhite CLA 2007-03-19 12:36:19 EDT
(In reply to comment #5)
> Whenever possible, we should condense a page's content so that it's viewable
> without scrolling.  I'll leave it up to you to decide if a fix is needed.

I agree.  We will address this in feature 74949.


*** This bug has been marked as a duplicate of bug 74949 ***
Comment 8 Navid Mehregani CLA 2007-03-28 18:40:39 EDT
Paul, this is a regression.  I don't think it should be tracked under a feature.  I'm attaching the screenshots for the same manual test file that's opened in a 4.4 driver and a 4.2.1.1 driver in order for you to better see the difference. 

The way we're displaying it now looks very strange!

I really think we should fix this, since it's a regression.  I'm reopening the defect so it can be addressed.
Comment 9 Navid Mehregani CLA 2007-03-28 18:42:59 EDT
Created attachment 62306 [details]
This is how it should be displayed.  Used the 4.2.1.1 driver.
Comment 10 Navid Mehregani CLA 2007-03-28 18:44:11 EDT
Created attachment 62307 [details]
This is how it's currently displayed in the 4.4 driver.  Note that this is the same test file I've opened
Comment 11 Paul Slauenwhite CLA 2007-03-29 09:18:07 EDT
(In reply to comment #8)

Given that this usability issue is a regression, we will investigate in i3.  However, this is not a major defect (see http://www.eclipse.org/tptp/home/documents/process/development/bugzilla.html).
Comment 12 Navid Mehregani CLA 2007-03-29 09:44:33 EDT
I marked it as a major since it's a regression.  If you think it should be treated as a normal defect, I'll trust your judgement.
Comment 13 Jerome Gout CLA 2007-03-29 10:14:33 EDT
Well, it seems come from the fact that the layout is based on two columns of the same width. And the width of the right one depends on the length of the test path (link). If this link is long the width of columns is big and then this is the result.

I add Bianca because maybe she would know a suspicious change on this page.
Comment 14 Paul Slauenwhite CLA 2007-03-29 13:48:13 EDT
This defect was reproduced in the TPTP-4.4.0-200703270100A driver in various test views/editors. 
Comment 15 Jerome Gout CLA 2007-04-18 04:41:44 EDT
As far as the Test log is concerned, it seems that Bianca did a fix committed under #131547 (setting the maxWidth of the TableWrapData instance that controls the size of the file name text).

Bianca could you, please confirm that ?
Comment 16 Jerome Gout CLA 2007-04-18 12:35:54 EDT
The Navid's issue (regression) is fixed.
Comment 17 Paul Slauenwhite CLA 2007-06-02 14:52:12 EDT
Reporter: Please verify and close in preparation for shutting down the TPTP 4.4 release.  Thanks.
Comment 18 amehrega CLA 2007-06-28 16:14:45 EDT
Closing