Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 175321 - Target platform reloaded on every keypress
Summary: Target platform reloaded on every keypress
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Linux-GTK
: P3 normal (vote)
Target Milestone: 3.3 M7   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 184526 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-02-23 12:13 EST by Jared Burns CLA
Modified: 2007-04-27 19:11 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jared Burns CLA 2007-02-23 12:13:26 EST 
Eclipse 3.3M5 (and also at least M4)
Linux-GTK

In the "Target Platform" preference page, the list of plugins is fully reloaded on every keypress in the Location field. This. makes. it. very. tedious. to. type. a. new. location.

For some reason, Win32 doesn't have this problem.
Comment 1 Wassim Melhem CLA 2007-02-23 12:28:12 EST 
There is a difference in ModifyEvent behavior in the swt combo box on Linux I believe, which has not been addressed and won't be any time soon.

I am afraid we have to find ta workaround.
Comment 2 Jared Burns CLA 2007-04-11 12:33:56 EDT 
Why is the Combo trying to reload in response to a selection change event anyway? Can't the reloading just be triggered by the reload button?

If the "reload on selection change" is really desired on some platforms, a simple workaround would be to disable it only on Linux-GTK.

fHomeText.addModifyListener(new ModifyListener() {
	public void modifyText(ModifyEvent e) {
		fNeedsReload = true;
	}
});
fHomeText.addSelectionListener(new SelectionAdapter() {
	public void widgetSelected(SelectionEvent e) {
		if (fFirstClick)
			fFirstClick = false;
		else {
			fPluginsTab.handleReload(new ArrayList());
			resetTargetProfile();
			fNeedsReload = false;
		}
	}
});
Comment 3 Wassim Melhem CLA 2007-04-14 23:17:08 EDT 
We have to take out this auto-load behavior as this is very annoying

see also bug 59661 for a related issue but on all platforms.

When the text is modified manually by the user, he will have to press 'Reload' to, well, reload.

If he forgets to press 'Reload' and tries to exit the preference dialog, PDE will pop up a reminder and ask to reload for him or cancel.

When the user chooses a new location via the Browse... button, we will auto-reload as usual.
Comment 4 Wassim Melhem CLA 2007-04-27 19:11:18 EDT 
*** Bug 184526 has been marked as a duplicate of this bug. ***