Community
Participate
Working Groups
I20070213-0907 - Open the Show View dialog and type "plug" - Select and open view "Plug-ins" - Open the Show View dialog again => "Plug-ins" is already selected (good) - type "pl" => depending on how fast you typed, different things happen: a) typed very fast: => "Plug-ins" stays selected (good) - press "Enter" => "Plug-in Dependencies" is selected. It's clearly wrong to select another entry on Enter. b) typed slowly => The folder "PDE" is selected, which does not make sense since they cannot be opened. I would expect that "Plug-ins" stays selected. - press "Enter" => "Plug-in Dependencies" is selected I would prefer if Enter just opened the selected view. Arrow_Down already moves the focus to the tree. The selection in the tree should not depend on typing speed, and it should be predictable. The originally selected view should stay selected as long as it matches the pattern. When the selected view gets removed from the tree, the selection should go to the next best match and stay there
Good one Markus... Added Boris since he's seen it and may have some input...
(In reply to comment #0) > The selection in the tree should not depend on typing speed This is no longer the case. The other problem is still there, on Enter we change the selection in the tree.
> > The selection in the tree should not depend on typing speed > > This is no longer the case. The other problem is still there, on Enter we > change the selection in the tree. It's still the case for me in I20090304-0834. To see b), type "p", wait until the tree has finished refreshing, then type "l".
Created attachment 145387 [details] Suggested fix to the bug
Mohamed, thank you for the patch! It is an interesting way to resolve this problem. There are two sections of code modified in the patch; the second section has this: + || previousFilterText + .equals(WorkbenchMessages.FilteredTree_ClearToolTip) Is this something needed? It seems to be triggered if, say, I type "Clear." in the filter, but I don't understand how that helps.
Created attachment 147426 [details] suggested fix to the pack (2)
(In reply to comment #5) > Mohamed, thank you for the patch! It is an interesting way to resolve this > problem. > > There are two sections of code modified in the patch; the second section has > this: > + || previousFilterText > + .equals(WorkbenchMessages.FilteredTree_ClearToolTip) > > Is this something needed? It seems to be triggered if, say, I type "Clear." in > the filter, but I don't understand how that helps. Sorry , it was a mistake , i edit it and resubmitted the patch its || previousFilterText > + .equals(WorkbenchMessages.FilteredTree_FilterMessage)
This seems to work well. "Suggested Fix 2" applied to CVS Head. Thank you!
Verified in I20091027-0100.
