Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 174107 - VM Args not getting copied from .product to ini file in Mac build
Summary: VM Args not getting copied from .product to ini file in Mac build
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Build (show other bugs)
Version: 3.2.1   Edit
Hardware: All All
: P3 major with 1 vote (vote)
Target Milestone: 3.3.1   Edit
Assignee: pde-build-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-13 18:27 EST by Graham Miller CLA
Modified: 2007-11-13 17:45 EST (History)
2 users (show)

See Also:


Attachments
Project implementing test case (70.06 KB, application/octet-stream)
2007-02-13 18:28 EST, Graham Miller CLA
no flags Details
The correct result on Linux (6.82 KB, image/png)
2007-02-13 18:37 EST, Graham Miller CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Graham Miller CLA 2007-02-13 18:27:14 EST
Build ID: M20060921-0945

Steps To Reproduce:
1. Extract the attached file, mac-ini-copy-bug.tgz
2. Import the resulting project into eclipse.
3. Choose File->Export...->Eclipse product, and export as a MacOS x86 product, and possibly in one other configuration for reference.
4. Start the application on MacOS and the window title will be "Missing property", start it on any other platform (we used linux.gtk.x86), and the window title will be "Property: my_application_window_title".

More information:
The attached project is based on the "Hello RCP" template project.  It simply reads a Java system property by calling 'System.getProperty("mac.ini.copy.bug.property")', and uses the resulting value to set the title of the application window.  The system property should be passed into the runtime by a line that looks something like '-Dmac.ini.copy.bug.property=...'  that should live in <launcher>.ini, in this case macinicopybug.ini.  Note that the application window title should be the same on all platforms, but it is incorrect on the Mac.

This works perfectly in the Linux build, for example, but in the MacOS build, the file located at macinicopybug.app/Contents/MacOS/macinicopybug.ini contains no trace of this argument.

In digging around in the build system, we found that BrandingIron.java (in the org.eclipse.pde.build plugin) seems to copy a standard .ini file into place, possibly overwriting the one containing custom arguments (take a look at BrandingIron.copyMacIni(...).


We first noticed this bug as part of our automated build system that uses the ant-based PDE build.  Please do not close this bug until we can verify that any fix also works in a headless PDE build.
Comment 1 Graham Miller CLA 2007-02-13 18:28:19 EST
Created attachment 58922 [details]
Project implementing test case
Comment 2 Graham Miller CLA 2007-02-13 18:37:49 EST
Created attachment 58923 [details]
The correct result on Linux

This shows the correct application title with the application running on Linux.
Comment 3 Andrew Niefer CLA 2007-11-13 17:24:07 EST
*** Bug 198559 has been marked as a duplicate of this bug. ***
Comment 4 Andrew Niefer CLA 2007-11-13 17:45:21 EST
This is fixed by changes for bug 192127.  Please try 3.3.1(.1) and reopen if this is not the case.