Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 174020 - Background colour makes variable value unreadable in variables view
Summary: Background colour makes variable value unreadable in variables view
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.3   Edit
Hardware: Macintosh Mac OS X - Carbon (unsup.)
: P3 normal with 5 votes (vote)
Target Milestone: 3.4 M1   Edit
Assignee: Darin Wright CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 195471 195667 195927 196488 203459 204944 205537 225662 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-02-13 11:23 EST by Martin Novák CLA
Modified: 2008-07-02 16:42 EDT (History)
10 users (show)

See Also:


Attachments
Screenshot of the situation (33.15 KB, image/png)
2007-02-13 11:25 EST, Martin Novák CLA
no flags Details
Patch (2.88 KB, patch)
2007-07-18 11:56 EDT, Curtis Windatt CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Novák CLA 2007-02-13 11:23:59 EST
I use dark blue background color for text editors, and I have all syntax highlight according to this colour scheme. The problem is when I debug code, JDT apparently uses syntax highlight for variable details. This is ok, but you don't set background colour for the view. This makes variable details a bit unreadable.
Comment 1 Martin Novák CLA 2007-02-13 11:25:02 EST
Created attachment 58863 [details]
Screenshot of the situation
Comment 2 Curtis Windatt CLA 2007-05-16 13:42:18 EDT
Deferred.  It is too late in 3.3 to make a change like this.

Adding this functionality would require a significant change.  To have custom settings, we would have to create four new appearance preferences (background/foreground colours and background/foreground highlight colours).  Alternatively we could take the settings from the AbstractTextEditor, but those preferences were not intended to be used elsewhere, so using them would require a lot of additional colour management by the detail pane.
Comment 3 Luke Maurer CLA 2007-07-03 18:30:07 EDT
You do realize that the text is syntax highlighted? You're already pulling in a whole lot more than a background color.

If we can't change the background in the detail pane, we need to be able to turn off its syntax highlighting (which seems rather pointless to me anyway).
Comment 4 Curtis Windatt CLA 2007-07-09 11:57:33 EDT
*** Bug 195471 has been marked as a duplicate of this bug. ***
Comment 5 Curtis Windatt CLA 2007-07-10 10:05:01 EDT
*** Bug 195927 has been marked as a duplicate of this bug. ***
Comment 6 Curtis Windatt CLA 2007-07-10 10:11:35 EDT
Syntax colouring is provided by the JFace source viewer, background colouring is not.  Background colouring is specific to editors and is not easily available to other views.  This has to work for more than just Java.

Marking as a 3.4 candidate.  Needs investigation.
Comment 7 Luke Maurer CLA 2007-07-10 15:08:45 EDT
Good, thanks - it does seem like the incongruous handling of foreground and background colors is something of a root cause (here and elsewhere).

In the meantime, though, I would like my detail pane back :-) Might it be reasonable for 3.3.1 to disable (optionally?) syntax highlighting in the detail pane?
Comment 8 Martin Novák CLA 2007-07-10 16:36:52 EDT
(In reply to comment #3)

Seems to me to be syntax highlight. Try this simple code, and set breakpoint to system.out.println and see the content of sz. Return does have different colour than '11'.

public class Test {
	public static void main(String[] args) {
		String sz = "return 11";
		System.out.println(sz);
	}
}

I would also turn off the syntax highlight, and use a colour settings from preference pane: general->editors->text editors, or neutral black and white. Syntax colouring in the variable view is pointless according to me because who uses java code in strings in java source? It would make sense more to hightlight sql or something like that, but I cannot imagine this to be really implemented... [-;
Comment 9 Luke Maurer CLA 2007-07-10 19:19:47 EDT
Yes, it's definitely the syntax highlighting that's to blame. It's especially noticeable when debugging reflection code, since classes, methods, etc. tend to output well-formed Java signatures in toString().
Comment 10 Curtis Windatt CLA 2007-07-16 11:00:48 EDT
*** Bug 195667 has been marked as a duplicate of this bug. ***
Comment 11 Curtis Windatt CLA 2007-07-18 11:56:37 EDT
Created attachment 74070 [details]
Patch

This patch removes the syntax highlighting and other java syntax features from the detail pane (when debugging java).  Only content assist was kept (useful for assigning values and inspecting statements).
Comment 12 Curtis Windatt CLA 2007-07-18 12:01:04 EDT
If possible, please try out the patch against a recent build.  Review and leave a comment if there are any problems.

I am targetting this patch for 3.4 M1.
Comment 13 Curtis Windatt CLA 2007-07-23 12:35:57 EDT
Did some more testing then applied the patch.

Tghe syntax highlighting is not very useful in the detail pane, but I'm still expecting a bug about the missing colouring any second now :)

Comment 14 Curtis Windatt CLA 2007-07-23 12:36:20 EDT
Darin, please review.
Comment 15 Darin Wright CLA 2007-07-24 16:13:44 EDT
Verified.
Comment 16 Curtis Windatt CLA 2007-07-25 12:37:40 EDT
*** Bug 196488 has been marked as a duplicate of this bug. ***
Comment 17 Eclipse Webmaster CLA 2007-07-29 09:21:45 EDT
Changing OS from Mac OS to Mac OS X as per bug 185991
Comment 18 Curtis Windatt CLA 2007-09-14 13:48:22 EDT
*** Bug 203459 has been marked as a duplicate of this bug. ***
Comment 19 Darin Wright CLA 2007-09-30 15:17:31 EDT
*** Bug 204944 has been marked as a duplicate of this bug. ***
Comment 20 Curtis Windatt CLA 2007-10-05 12:01:50 EDT
*** Bug 205537 has been marked as a duplicate of this bug. ***
Comment 21 Curtis Windatt CLA 2008-04-04 09:42:25 EDT
*** Bug 225662 has been marked as a duplicate of this bug. ***