Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 172935 - [JarProcessor] Handle case when pack200 fails
Summary: [JarProcessor] Handle case when pack200 fails
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Update (deprecated - use Eclipse>Equinox>p2) (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M7   Edit
Assignee: Platform-Update-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 178882
Blocks: 149970 178886
  Show dependency tree
 
Reported: 2007-02-05 16:48 EST by Andrew Niefer CLA
Modified: 2007-06-06 11:36 EDT (History)
2 users (show)

See Also:


Attachments
patch to update.core (2.10 KB, patch)
2007-02-05 16:48 EST, Andrew Niefer CLA
no flags Details | Diff
error log from N200702210010 build (2.01 KB, text/plain)
2007-02-21 09:20 EST, Kim Moir CLA
no flags Details
all pack logs from N200702210010 build (25.96 KB, application/zip)
2007-02-21 09:22 EST, Kim Moir CLA
no flags Details
updated patch (5.19 KB, patch)
2007-02-21 13:18 EST, Andrew Niefer CLA
no flags Details | Diff
new jar (568.73 KB, application/octet-stream)
2007-02-21 13:21 EST, Andrew Niefer CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Niefer CLA 2007-02-05 16:48:12 EST
The eclipse builds have a recurring problem:
Warning: Could not find
file/builds/N200607070010/src/N20060707-0010/eclipse-master-N20060707-0010.zip
Which is ultimately caused by a pack200 operation failing to produce the expected output and the JarProcessor failing with an IOException.

The JarProcessor should be more gracefull about this case and produce an error/warning in this case and it can fall back to the unpacked jar.
Comment 1 Andrew Niefer CLA 2007-02-05 16:48:58 EST
Created attachment 58286 [details]
patch to update.core
Comment 2 Kim Moir CLA 2007-02-21 09:20:18 EST
Created attachment 59474 [details]
error log from N200702210010 build

The build seems to be having the same problem.

We are using org.eclipse.update.core_3.2.100.200702051614.jar in the build, the jar provided in bug 149970.
Comment 3 Kim Moir CLA 2007-02-21 09:22:22 EST
Created attachment 59475 [details]
all pack logs from N200702210010 build
Comment 4 Andrew Niefer CLA 2007-02-21 13:18:29 EST
Created attachment 59501 [details]
updated patch
Comment 5 Andrew Niefer CLA 2007-02-21 13:21:16 EST
Created attachment 59502 [details]
new jar

New update.core jar containing the new patch
Comment 6 Kim Moir CLA 2007-02-21 13:31:10 EST
Thanks released to basebuilder and starting a test build.
Comment 7 Andrew Niefer CLA 2007-04-04 13:00:16 EDT
done in HEAD