Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 172721 - Extension point schema editor opens as read-only from plugin.xml editor
Summary: Extension point schema editor opens as read-only from plugin.xml editor
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M7   Edit
Assignee: Brian Bauman CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 172718 178759 (view as bug list)
Depends on:
Blocks: 393797
  Show dependency tree
 
Reported: 2007-02-02 16:48 EST by James Stuckey CLA
Modified: 2012-11-07 13:07 EST (History)
5 users (show)

See Also:

Attachments
Patch for pde.ui (1.86 KB, patch)
2007-03-22 11:02 EDT, Brian Bauman CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Stuckey CLA 2007-02-02 16:48:19 EST 
Build ID:  I20061214-1445

Steps To Reproduce:
1. Open a plugin.xml file for a plugin which declares 1 or more extension points
2. From the 'Extension Points' tab in the editor select the 'Open extension point schema' link.
3. The editor opens read-only.

Is this intentional?  If so it was surprising.  You are in an editor that is modifiable editing a resource that is associated with the contents of that editor.


More information:
Comment 1 Wassim Melhem CLA 2007-02-02 16:51:58 EST 
*** Bug 172718 has been marked as a duplicate of this bug. ***
Comment 2 James Stuckey CLA 2007-02-02 16:55:25 EST 
Ugh- this was created after 172718 by an errant refresh of my browser.

My example could have been clearer.  In my case the plugin was in my
workspace.  I would not have been surprised if it had not been in my workspace.

You can reproduce by creating a new plugin project in your workspace, creating
a new extension point/schema and then following the steps below.  Note that the
schema editor opened when you are creating the extension point is modifiable so
you would have to close that first.
Comment 3 Wassim Melhem CLA 2007-02-02 16:58:43 EST 
yes, this is certainly a bug.
Comment 4 Brian Bauman CLA 2007-03-22 10:41:04 EDT 
*** Bug 178759 has been marked as a duplicate of this bug. ***
Comment 5 Brian Bauman CLA 2007-03-22 11:02:56 EDT 
Created attachment 61683 [details]
Patch for pde.ui

Mike, I know you are backed up on bugs and I have a tested fix which should work, so I will go ahead and take this one off your hands.  Created patch for safe keeping until 3.3M6 is finalized and we can release code for M7.
Comment 6 Brian Bauman CLA 2007-03-26 21:55:52 EDT 
To open a schema file, we get the URL of the schema.  Normally, we pass this URL to the schema editor and it opens the Schema editor like an external editor making it read only.  Now, when we open a schema we check to see if the URL specifies a subdirectory of the workspace.  If it does, we then check to see if the sub folder is a valid resources in the workspace.  If it is, we then open it as you would expect the file to be opened in the workspace.
Comment 7 Eike Stepper CLA 2012-10-30 03:06:02 EDT 
Strange, I experience this same problem with:

Eclipse PDE Plug-in Developer Resources	3.8.1.v20120814-104528-7c7vFixFFt6Zr5aC6KM3OJSWW
Comment 8 Curtis Windatt CLA 2012-11-07 13:07:28 EST 
(In reply to comment #7)
> Strange, I experience this same problem with:
> 
> Eclipse PDE Plug-in Developer Resources
> 3.8.1.v20120814-104528-7c7vFixFFt6Zr5aC6KM3OJSWW

Thanks for catching this, Brian no longer works on PDE so the reopened bug never showed up in the inbox.  I have cloned this report as bug 393797.