Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 170972 - Need to add launcher to required plug-ins
Summary: Need to add launcher to required plug-ins
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M5   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-18 15:53 EST by DJ Houghton CLA
Modified: 2007-02-05 18:06 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description DJ Houghton CLA 2007-01-18 15:53:18 EST
build n0118-0010

When you create a new product, add a plug-in which contains an RCP app, and then export it, the new launcher plug-ins are not a part of the export but they are required to run the app.

- create new plug-in project with a Hello World RCP app
- create a new product file
- in the product editor go to the Configuration tab
- add your project and Add Required

Note that org.eclipse.equinox.launcher and its fragments are not in the list.

Export the product and try to run it. It will fail to run because it is missing these launcher bundles.

Because there is no direct dependency on the launcher bundle (that's why its not added), should we automatically be adding it in PluginSection#handleAddRequired?
Comment 1 Wassim Melhem CLA 2007-01-18 16:01:52 EST
omg, DJ is the PDE slayer today :)
Comment 2 DJ Houghton CLA 2007-01-18 16:30:06 EST
I am just waiting for you to tell me to mark this one as invalid too so my day can be complete. :-)
Comment 3 Wassim Melhem CLA 2007-01-18 16:36:32 EST
it is valid, but no plugin depends on the launcher plugin.

So instead of tweaking the 'Add required plug-ins' function, we were contemplating on implicitly adding the launcher plugin/fragment when building the product (much like we currently implicitly add startup.jar).

This way, all existing .product files will continue to work as-is.
Comment 4 Wassim Melhem CLA 2007-02-05 18:06:29 EST
done as per comment 3.