This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 170866 - [Collab] Integrate RT shared editing into eclipse.org CVS
Summary: [Collab] Integrate RT shared editing into eclipse.org CVS
Status: RESOLVED FIXED
Alias: None
Product: ECF
Classification: RT
Component: ecf.core (show other bugs)
Version: 1.0.1   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 1.1.0   Edit
Assignee: Remy Suen CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-17 23:50 EST by Remy Suen CLA
Modified: 2007-08-26 16:23 EDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2007-01-17 23:50:39 EST
In light of the announcement on Monday's conference call about CQ deadlines, we should submit a CQ for this work so that we can integrate it into CVS HEAD in preparation for Europa.

Scott and Mustafa, I don't envision there are any "legal barriers" since it's all under the EPL, right?
Comment 1 Scott Lewis CLA 2007-01-19 13:01:07 EST
(In reply to comment #0)
> In light of the announcement on Monday's conference call about CQ deadlines, we
> should submit a CQ for this work so that we can integrate it into CVS HEAD in
> preparation for Europa.
> 
> Scott and Mustafa, I don't envision there are any "legal barriers" since it's
> all under the EPL, right?

Right...no legal barriers if Mustafa contributes under EPL.

But we should get a CQ in if we're going to try to do this soon.


Comment 2 Mustafa K. Isik CLA 2007-01-19 22:36:10 EST
It's all EPL :)


(In reply to comment #1)
> (In reply to comment #0)
> > In light of the announcement on Monday's conference call about CQ deadlines, we
> > should submit a CQ for this work so that we can integrate it into CVS HEAD in
> > preparation for Europa.
> > 
> > Scott and Mustafa, I don't envision there are any "legal barriers" since it's
> > all under the EPL, right?
> 
> Right...no legal barriers if Mustafa contributes under EPL.
> 
> But we should get a CQ in if we're going to try to do this soon.
> 

Comment 3 Remy Suen CLA 2007-01-19 22:55:32 EST
Mustafa, the latest revision of your code is the that's currently at OSUOSL's repository, correct? If not, can you commit them and then let us know on this bug? To fill out the CQ, we'll need you to answer a couple of questions.

Please provide any information you may have regarding intellectual property
rights such as patents and trademarks if applicable.

Is there any cryptography involved? If yes, please provide details.

Do you acknowledge that you wrote 100% of this code? If not you need to provide
us with the contact information of the other personnel, what they contributed,
and the relative percentage of the work split-up between you and them.
Comment 4 Boris Bokowski CLA 2007-01-25 23:56:11 EST
Mustafa, did you already respond to comment #3?
Comment 5 Mustafa K. Isik CLA 2007-01-26 05:42:59 EST
(In reply to comment #3)
> Mustafa, the latest revision of your code is the that's currently at OSUOSL's
> repository, correct? 

Yes Remy.
 
> Please provide any information you may have regarding intellectual property
> rights such as patents and trademarks if applicable.

I am not aware of any such legal restrictions.

> Is there any cryptography involved? If yes, please provide details.

No crypto-stuff involved.
 
> Do you acknowledge that you wrote 100% of this code?

Yes I do. The only other code involved was Ken Gilmer's initial shared editing material, which I refactored and extended to support operational transformations etc.

Sorry guys if my answers lag behind, but I'm in the middle of my finals :)
Comment 6 Remy Suen CLA 2007-01-26 10:02:19 EST
(In reply to comment #5)
> Yes I do. The only other code involved was Ken Gilmer's initial shared editing
> material, which I refactored and extended to support operational
> transformations etc.

Several classes in the org.eclipse.ecf.example.sharededitor.cola.message package does not have license headers. There are @author tags so those can be fixed except for AbstractMessage that has neither. Scott, would we still fill in 100% for code contribution or should there be a split with Ken? Can we bring Ken into this discussion?

> Sorry guys if my answers lag behind, but I'm in the middle of my finals :)

No problems Mustafa, good luck with your exams.
Comment 7 Remy Suen CLA 2007-03-21 16:20:05 EDT
Adding Ken to CC to help address the CQ.
Comment 8 Ken Gilmer CLA 2007-05-28 15:12:35 EDT
Remy,

  I took a look at your additions on the 25th.  Looks good to me.  Regarding my source contributions, everything that I did either was pre-existing example code that I adapted or code I wrote from scratch.  Please LMK if I can provide further assistance on the bugzilla.
Comment 9 Remy Suen CLA 2007-05-28 18:32:40 EDT
Okay, so who actually wrote AbstractMessage? And what was the relative split of the code? I need these relative percentages to draft up the CQ. I noticed there's a Composent license header in the preference page, so I'll allocate a 5% to Scott I guess. ;p
Comment 10 Ken Gilmer CLA 2007-05-28 19:18:52 EDT
Hmmm,well the class in question consists of 4 lines of code.  I do not recall either way.  I did some detective work and found org.eclipse.ecf.presence.collab.ui.URLShare.serialize() that looks pretty much the same.  This code was checked in by Scott, so I reckon he deserves the credit for AbstractMessage as well.
Comment 11 Scott Lewis CLA 2007-05-28 19:47:42 EDT
(In reply to comment #10)
> Hmmm,well the class in question consists of 4 lines of code.  I do not recall
> either way.  I did some detective work and found
> org.eclipse.ecf.presence.collab.ui.URLShare.serialize() that looks pretty much
> the same.  This code was checked in by Scott, so I reckon he deserves the
> credit for AbstractMessage as well.
> 

:) :).

I wrote URLShare.serialize(), but not AbstractMessage.toByteArray.  All attributions on this go to Ken...even though I think I *might* have written one of the first 100 or so copies of these lines in, say, 1995:

		ByteArrayOutputStream bouts = new ByteArrayOutputStream();
		ObjectOutputStream douts = new ObjectOutputStream(bouts);
		douts.writeObject(this);

I wish I could copyright that...oh yeah, I'm not big on copyrights (doh!)

:)



Comment 12 Remy Suen CLA 2007-05-28 21:00:45 EDT
Committers, I have filed CQ 1558 for this.
https://dev.eclipse.org/ipzilla/show_bug.cgi?id=1558
Comment 13 Scott Lewis CLA 2007-07-24 19:23:35 EDT
(In reply to comment #12)
> Committers, I have filed CQ 1558 for this.
> https://dev.eclipse.org/ipzilla/show_bug.cgi?id=1558
> 

CQ 1558 has been approved (modulo a tardy +1 from PMC), so work can continue on this.  Should this be reassigned to Mustafa?

Setting target milestone to 1.1.0.
Comment 14 Remy Suen CLA 2007-08-26 16:23:50 EDT
Mustafa's code is now in CVS.

org.eclipse.ecf/examples/plugins/org.eclipse.ecf.example.sharededitor.cola