Comment 1 Mik Kersten 2007-01-05 16:50:36 EST

Eugene: are you interested in adding this hyperlink detector?  BugzillaTaskHyperlinkDetector can be used as an example, but we might want to use the Jira case as a driver for making this not require a custom IHyperlinkDetector.

Comment 2 Eugene Kuleshov 2007-01-06 02:57:23 EST

Will try to look at this next week, unless someone will take it before...

Comment 3 Eugene Kuleshov 2007-01-16 02:51:16 EST

Mik, I committed basic implementation. However TasksUiUtil.openRepositoryTask() is not able to find task by key and open it in a web browser. See bug 170587

Comment 4 Eugene Kuleshov 2007-01-16 02:51:21 EST

Created attachment 56948 [details]
mylar/context/zip

Comment 5 Mik Kersten 2007-01-25 15:28:31 EST

Eugene: is this done with your latest changes?

Comment 6 Eugene Kuleshov 2007-01-25 15:42:32 EST

Nope. It still gives a error like this. Maybe we can try to replace TasksUiUtil.openRepositoryTask() call with OpenRepositoryTaskJob or something like that... though it would need to look in the task list first.

It is also weird that JIRA editor in the trunk don't have web browser tab and Open With Web Browser action does not work either.

java.lang.RuntimeException: invalid handle for task, can not contain: -, was: MNGECLIPSE-59
	at org.eclipse.mylar.tasks.core.AbstractRepositoryTask.getHandle(AbstractRepositoryTask.java:138)
	at org.eclipse.mylar.tasks.ui.TasksUiUtil.openRepositoryTask(TasksUiUtil.java:121)
	at org.eclipse.mylar.internal.jira.core.ui.JiraHyperLink.open(JiraHyperLink.java:50)
	at org.eclipse.jface.text.hyperlink.HyperlinkManager.mouseUp(HyperlinkManager.java:394)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:137)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:928)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3465)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3079)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1945)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1909)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:425)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:95)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:585)
	at org.eclipse.equinox.internal.app.EclipseAppContainer.callMethod(EclipseAppContainer.java:522)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:147)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:104)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:74)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:170)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:585)
	at org.eclipse.core.launcher.Main.invokeFramework(Main.java:339)
	at org.eclipse.core.launcher.Main.basicRun(Main.java:283)
	at org.eclipse.core.launcher.Main.run(Main.java:984)
	at org.eclipse.core.launcher.Main.main(Main.java:959)

Comment 7 Eugene Kuleshov 2007-02-02 00:12:43 EST

Mik, reassigning this to you because it depends on bug 170587

Comment 8 Mik Kersten 2007-02-02 15:53:10 EST

OK, will review next week.  Btw, Rob mentioned that Open Corresponding Task is currently broken in the Synchronize view.  I haven't had a chance to investigate.

Comment 9 Eugene Kuleshov 2007-02-02 19:32:01 EST

I had to put those on hold, because '-' issue and handle methods are going into the way everywhere.

Comment 10 Mik Kersten 2007-02-19 13:59:27 EST

Eugene has got this working, but a limitation in the framework is limiting for issues that are already in the Task List.  Upcoming changes should make it possible for this to extend to any issue so tentatively scheduling for M2.

Comment 11 Steffen Pingel 2007-03-08 20:43:34 EST

Please note that this will block the UI thread if the repository configuration is not available when the JiraTaskHyperlinkDetector is activated.

Eugene, anything left to do here or can we close this report?

Comment 12 Eugene Kuleshov 2007-03-08 20:53:47 EST

(In reply to comment #11)
> Please note that this will block the UI thread if the repository configuration
> is not available when the JiraTaskHyperlinkDetector is activated.
> 
> Eugene, anything left to do here or can we close this report?

Umm. Maybe to not block that thread? I thought I did it using OpenRepositoryTaskJob, so it should not block anything... Maybe Mik "fixed" that...

Comment 13 Steffen Pingel 2007-03-09 00:45:47 EST

The possible blocking occurs during the construction of the regular expression. That needs to be fixed as part of bug 168357. Note that Rob will fix bug 170679 to avoid the contribution of multiple hyperlink detectors.