Comment 1 Szymon Brandys 2006-12-29 07:16:45 EST

Created attachment 56245 [details]
For Tod's components

Comment 2 Tod Creasey 2007-01-03 08:47:13 EST

This also covers some of Paul's handler code so I am adding him here.

Comment 3 Tod Creasey 2007-01-03 09:54:12 EST

One issue (which I will fix myself)

in FullDecoratorRunnable you deleted the crash disable - here is what it should look like

   public void handleException(Throwable exception) {
        IStatus status = StatusUtil.newStatus(WorkbenchPlugin.PI_WORKBENCH, "Exception in Decorator", exception); //$NON-NLS-1$ 
    	StatusManager.getManager().handle(status);
    	decorator.crashDisable();
    }

I also noticed that a lot of the status building code is pretty long - we should look at making a better reusable facility for building these

Comment 4 Tod Creasey 2007-01-03 09:55:36 EST

Patch (with mentioned changes) released for build >20060103

Comment 5 Tod Creasey 2007-01-11 10:48:57 EST

Created attachment 56775 [details]
Rollback of changes .log

We will need manual rollbacks for FullDecoratorRunnable and LightweightDecoratorManager.

I have committed the rest of the patch

Comment 6 Tod Creasey 2007-01-11 10:49:49 EST

reopening for extra checks

Comment 7 Szymon Brandys 2007-01-11 10:57:59 EST

Created attachment 56776 [details]
Rollback for FullDecoratorRunnable and LightweightDecoratorManager

Comment 8 Tod Creasey 2007-01-11 12:57:55 EST

Patch released to build > 20070111