Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 168947 - [Apply Patch] PatchWizard should not request full path from IStorage containing a patch
Summary: [Apply Patch] PatchWizard should not request full path from IStorage containi...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.3   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.3 M5   Edit
Assignee: Michael Valenta CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-22 14:05 EST by Eugene Kuleshov CLA
Modified: 2007-02-06 09:31 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Kuleshov CLA 2006-12-22 14:05:14 EST 
Currently, PatchWizard is requesting full path from IStorage that contains patch. See line 123:

  fPatcher.setName(patch.getFullPath().toString());
  
It forced us to provide some bogus full path (else getting a NPE exception if patch.getFullPath() returns null), because we don't have any file laying around with patch content. I looked around and that full path value doesn't seem used after that. So, you probably should remove that call to getFullPath() or at least do an null check before converting full path to string.
Comment 1 Michael Valenta CLA 2007-01-03 11:03:00 EST 
Fix released to HEAD. I removed the name from the Patcher since it was never used.
Comment 2 Michael Valenta CLA 2007-02-06 09:31:43 EST 
Verified using I20070206-0010