Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 167893 - [Workbench] [RCP]Create an org.eclipse.ui.ide.application plug-in
Summary: [Workbench] [RCP]Create an org.eclipse.ui.ide.application plug-in
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.3 M5   Edit
Assignee: Tod Creasey CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 170005 172485
Blocks: 155299 164108
  Show dependency tree
 
Reported: 2006-12-13 13:36 EST by Tod Creasey CLA
Modified: 2007-02-21 09:37 EST (History)
13 users (show)

See Also:


Attachments
Patch to IDE and SDK (116.90 KB, patch)
2007-01-09 14:31 EST, Tod Creasey CLA
no flags Details | Diff
org.eclipse.ui.ide.application (65.37 KB, application/octet-stream)
2007-01-09 14:33 EST, Tod Creasey CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tod Creasey CLA 2006-12-13 13:36:39 EST
M4

We have many situations where people want to use our resource based APIs but cannot due to a required dependency on the IDE application.

Likewise we have code in the IDE that would like to use other plug-in but cannot due to a circular dependency (specifically the Common Navigator requires the resource parts of the IDE so we can't use it in the IDE without the circular dependency).

Looking at the code in IDE the vast majority of it could be moved to a resources based plug-in with only a small amount left in IDE to support the IDE application and the Resource Perspective.

This would allow
1) RCP apps to use our views like the Problems View with thier own application. Right now many are forced to subclass our (internal) application class to get this to work.

2) The resource navigator to rely only on the new org,eclipse.ui.workbench.resources plug-in thereby allowing the IDE to refer to it.
Comment 1 Boris Bokowski CLA 2006-12-14 10:56:15 EST
(In reply to comment #0)
> Looking at the code in IDE the vast majority of it could be moved to a
> resources based plug-in with only a small amount left in IDE to support the IDE
> application and the Resource Perspective.

I thought about this, and if there are no API problems, I believe we should do the following:

- Create a new plug-in org.eclipse.ui.ide.application.
- Move the IDE application and supporting classes into the new plug-in
  (assuming none of them are API).
- Fix some of the problems that people have when trying to use org.eclipse.ide
  without running or subclassing the IDE application class.

This would solve the cyclic dependency problem, and eventually, make org.eclipse.ui.ide a plug-in like any other.
Comment 2 Tod Creasey CLA 2007-01-03 07:57:31 EST
+1 for Boris's suggestion.
Comment 3 Dani Megert CLA 2007-01-03 09:09:34 EST
+1.
Comment 4 Tod Creasey CLA 2007-01-09 14:31:13 EST
Created attachment 56647 [details]
Patch to IDE and SDK
Comment 5 Tod Creasey CLA 2007-01-09 14:33:37 EST
Created attachment 56648 [details]
org.eclipse.ui.ide.application

Coupled with the attached patches this will fix Bug 155299, Bug 164108 and this bug. I will release this as soon as the PMC gets the new project added
Comment 6 Tod Creasey CLA 2007-01-09 16:36:20 EST
Patch and new plug-in released for build >20070109
Comment 7 Kim Moir CLA 2007-01-09 17:06:56 EST
platform feature updated with new org.eclipse.ui.ide.application plugin.
Comment 8 Dani Megert CLA 2007-02-01 10:54:16 EST
Note that this change can break existing clients, e.g. a client that currently only requires 'org.eclipse.ui.ide' and doesn't provide its own application. Did you discuss and accept that breakage?

Maybe a better solution would have been to extract the non-application part into its own plug-in (e.g. 'org.eclipse.ui.ide.base' or 'org.eclipse.ui.resources') and let 'org.eclipse.ui.ide' require that one and re-export all its APIs. Thoughts?
Comment 9 Tod Creasey CLA 2007-02-06 13:56:35 EST
Verified in 20070206-0010
Comment 10 Markus Keller CLA 2007-02-21 09:37:58 EST
Bug 172517 has reverted the application id to org.eclipse.ui.ide.workbench.

What about Dani's concerns from comment 8?
Did you add this to the 3.3 porting guide as a breaking change?