Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 166231 - [launching] history not updated properly
Summary: [launching] history not updated properly
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.3   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.3 M6   Edit
Assignee: Darin Wright CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-29 12:58 EST by Michael Rennie CLA
Modified: 2007-02-20 16:25 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2006-11-29 12:58:27 EST 
The launch histroy does not seem to update properly after launch configurations have been launched and deleted between launchs when favorite launch configurations are involved.

to reproduce:
1. make three configs A, B and C
2. make A a run favorite and launch it
3. launch B and C
4. launch A and then B again
5. open the launch dialog and delete B, close the dialog
6. says you will relaunch C, not A

expected: should relaunch A, not C
Comment 1 Michael Rennie CLA 2006-11-30 09:31:32 EST 
In our current implementation we have two disjoint listings of launch configs in the history, the "normal" configs and those that are "favorites". 

The problems seem to arise from maintaining two of these lists and having to decide when to choose one over the other when asking for last launches or changing the backing config of a history item.

This should be changed to use a simple LIFO queue design for all history items and handle favorites in a different way.
Comment 2 Michael Rennie CLA 2007-02-20 10:39:10 EST 
fixed in HEAD

see LaunchHistory, also see LaunchHistoryTests

note: make sure context launching is turned off to verify this fix...
Comment 3 Michael Rennie CLA 2007-02-20 10:39:26 EST 
please verify Darin W
Comment 4 Darin Wright CLA 2007-02-20 14:52:30 EST 
Followed the steps in a new workspace. It correctly launched 'A', but the hover help showed it would launch 'B' (which did not exist any more).
Comment 5 Michael Rennie CLA 2007-02-20 15:56:23 EST 
oops...we should have been firing a launch history changed event...
Comment 6 Darin Wright CLA 2007-02-20 16:24:59 EST 
Fixed.
Comment 7 Darin Wright CLA 2007-02-20 16:25:07 EST 
Verified.