Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 165733 - connectors' search page that fails to load will break other search pages
Summary: connectors' search page that fails to load will break other search pages
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 2.0 M1   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-23 20:11 EST by Eugene Kuleshov CLA
Modified: 2007-01-22 20:45 EST (History)
0 users

See Also:


Attachments
mylar/context/zip (917 bytes, application/octet-stream)
2006-11-23 20:36 EST, Mik Kersten CLA
no flags Details
Here is some proof (15.98 KB, image/gif)
2006-11-23 20:40 EST, Eugene Kuleshov CLA
no flags Details
adds an additional wrapper composite (12.81 KB, text/plain)
2007-01-21 23:04 EST, Steffen Pingel CLA
no flags Details
mylar/context/zip (7.77 KB, application/octet-stream)
2007-01-21 23:05 EST, Steffen Pingel CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Kuleshov CLA 2006-11-23 20:11:51 EST
I noticed that task Search UI (Ctrl-H) is completely broken in 0.9 build.
Comment 1 Eugene Kuleshov CLA 2006-11-23 20:15:06 EST
It seems ok in the HEAD, though worth to verify.

Also note that repository selection drop down should be read only and should show the repository labels.
Comment 2 Mik Kersten CLA 2006-11-23 20:36:22 EST
"completely broken" is not very useful information at puts the burden of investigation on the the triager, so please provide more details on bug reports in the future and ideally steps to reproduce.  Nevertheless since this sounded like it could be critical I just checked it against my 0.9 install.  I could not reproduce any problems.  I'll assume for now it could be repository timeouts from eclipse.org.

I made the drop down read only.  Labels and icons not yet supported but feel free to file a bug for that.
Comment 3 Mik Kersten CLA 2006-11-23 20:36:23 EST
Created attachment 54446 [details]
mylar/context/zip
Comment 4 Eugene Kuleshov CLA 2006-11-23 20:40:56 EST
Created attachment 54447 [details]
Here is some proof
Comment 5 Mik Kersten CLA 2006-11-23 22:51:29 EST
I tried again and still can not reproduce this failure on either 0.9 or HEAD, and where search is running fine for both Bugzilla and JIRA.  I'm not running with fresh workspaces.  If you have steps to reproduce (e.g. install fresh workspace, never run a query, ...) please post.
Comment 6 Eugene Kuleshov CLA 2006-11-23 23:06:38 EST
Ok. It looks like it is related to JIRA auth issues. When JIRA panel is initialized there is probably call to repository (no idea why), which is failed, so whole panes is broken. Then it looks like that after that it somehow affects other panels.

I also noticed that repository is not preselected when you open this search for the first time.

Here is the auth exception.

org.tigris.jira.core.service.exceptions.AuthenticationException
	at org.tigris.jira.internal.core.service.soap.SoapJiraService.getProjects(SoapJiraService.java:190)
	at org.tigris.jira.core.service.CachedRpcJiraServer.initializeProjects(CachedRpcJiraServer.java:192)
	at org.tigris.jira.core.service.CachedRpcJiraServer.getProjects(CachedRpcJiraServer.java:221)
	at org.eclipse.mylar.internal.jira.ui.wizards.JiraQueryPage$23.getElements(JiraQueryPage.java:822)
	at org.eclipse.jface.viewers.StructuredViewer.getRawChildren(StructuredViewer.java:930)
	at org.eclipse.jface.viewers.StructuredViewer.getFilteredChildren(StructuredViewer.java:870)
	at org.eclipse.jface.viewers.StructuredViewer.getSortedChildren(StructuredViewer.java:987)
	at org.eclipse.jface.viewers.AbstractListViewer.inputChanged(AbstractListViewer.java:335)
	at org.eclipse.jface.viewers.ContentViewer.setInput(ContentViewer.java:250)
	at org.eclipse.jface.viewers.StructuredViewer.setInput(StructuredViewer.java:1564)
	at org.eclipse.mylar.internal.jira.ui.wizards.JiraQueryPage.createProjectsViewer(JiraQueryPage.java:843)
	at org.eclipse.mylar.internal.jira.ui.wizards.JiraQueryPage.createControl(JiraQueryPage.java:241)
	at org.eclipse.mylar.internal.tasks.ui.TaskSearchPage.createPage(TaskSearchPage.java:116)
	at org.eclipse.mylar.internal.tasks.ui.TaskSearchPage.displayQueryPage(TaskSearchPage.java:142)
	at org.eclipse.mylar.internal.tasks.ui.TaskSearchPage.access$1(TaskSearchPage.java:126)
	at org.eclipse.mylar.internal.tasks.ui.TaskSearchPage$1.widgetSelected(TaskSearchPage.java:101)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:90)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:925)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3463)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3077)
	at org.eclipse.jface.window.Window.runEventLoop(Window.java:820)
	at org.eclipse.jface.window.Window.open(Window.java:796)
	at org.eclipse.search.internal.ui.OpenSearchDialogAction.run(OpenSearchDialogAction.java:54)
	at org.eclipse.search.internal.ui.OpenSearchDialogAction.run(OpenSearchDialogAction.java:45)
	at org.eclipse.ui.internal.PluginAction.runWithEvent(PluginAction.java:253)
	at org.eclipse.ui.internal.WWinPluginAction.runWithEvent(WWinPluginAction.java:229)
	at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:539)
	at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:488)
	at org.eclipse.jface.action.ActionContributionItem$6.handleEvent(ActionContributionItem.java:441)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:925)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3463)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3077)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1924)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1888)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:419)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:95)
	at org.eclipse.core.internal.runtime.PlatformActivator$1.run(PlatformActivator.java:78)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:104)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:74)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:348)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:165)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:585)
	at org.eclipse.core.launcher.Main.invokeFramework(Main.java:341)
	at org.eclipse.core.launcher.Main.basicRun(Main.java:285)
	at org.eclipse.core.launcher.Main.run(Main.java:987)
	at org.eclipse.core.launcher.Main.main(Main.java:962)
Comment 7 Mik Kersten CLA 2006-11-23 23:44:10 EST
Great, thanks for figuring that out!  These don't happen as much any more on the latest, but I think that they are still possible.  On that bug please comment which repository you saw this with, if it is a public repository.  I can't tell if it's something we're doing wrong or if it is timeouts.

*** This bug has been marked as a duplicate of 164052 ***
Comment 8 Eugene Kuleshov CLA 2006-11-24 00:24:14 EST
You ca n use

http://developer.atlassian.com/jira (dashboard)
http://jira.codehaus.org 
http://opensource.atlassian.com/projects/spring 

I think that this issue have a different point. Namely, JIRA query panel should not break initialization if data providers fail to load. So, user should see an empty UI, but should be able to reload these attributes using "refresh" button.
Comment 9 Mik Kersten CLA 2006-11-24 10:29:28 EST
Yes, it should be robust to that.  When looking into this we should also check whether we should insulate other search pages can't have a similar failure (I think the Bugzilla page is OK with connection failures).
Comment 10 Robert Elves CLA 2006-11-24 22:29:38 EST
Update: Breakage no longer occurs. Hyperlink now appears indicating failure to load and opens TaskRepositorySettingsPage then closes search dialog. Needs improvement but can look into post 1.0.
Comment 11 Mik Kersten CLA 2006-12-20 17:58:45 EST
Steffen's patch for bug 168356 fixed this according to my limited testing.

Rob: when you are back you might want to check against this part of the manual tests.
Comment 12 Mik Kersten CLA 2006-12-20 18:00:19 EST

*** This bug has been marked as a duplicate of bug 168356 ***
Comment 13 Steffen Pingel CLA 2006-12-21 10:30:32 EST
If we add a wrapper Composite for each connector's search page we can make the dialog more robust (see bug 168356 comment 11). This will be addressed after 1.0.1 has been released.
Comment 14 Steffen Pingel CLA 2007-01-21 23:04:59 EST
Created attachment 57235 [details]
adds an additional wrapper composite

The patch loosely follows the implementation of SearchDialog by using a data property of the wrapper composite to store a reference to the actual search page object. I have done some minor source cleanup and couldn't resist the temptation to remove the group border of the repository chooser. 

I have done limited manual testing. Please review the patch before applying.
Comment 15 Steffen Pingel CLA 2007-01-21 23:05:01 EST
Created attachment 57236 [details]
mylar/context/zip
Comment 16 Robert Elves CLA 2007-01-22 15:51:43 EST
I'll have a look....
Comment 17 Robert Elves CLA 2007-01-22 17:43:00 EST
Great! Tested with failing search page and all worked perfectly. Patch applied.
Comment 18 Eugene Kuleshov CLA 2007-01-22 17:55:09 EST
(In reply to comment #17)
> Great! Tested with failing search page and all worked perfectly. Patch applied.

Rob, there is something with resizing of the internal search panel. It does grab horizonal space for bugzilla, but not for jira; but it don't grab vertical for either of them. Should I fill a separate issue for this?
Comment 19 Steffen Pingel CLA 2007-01-22 20:45:15 EST
As far as I can tell the resizing issue is not related to the patch. I can reproduce it with the latest release also. Eugene, please open a new report.