Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 164495 - Remove garbage when imported signed plug-ins
Summary: Remove garbage when imported signed plug-ins
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M4   Edit
Assignee: Brian Bauman CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-14 12:03 EST by Wassim Melhem CLA
Modified: 2006-11-14 14:39 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wassim Melhem CLA 2006-11-14 12:03:07 EST 
When importing signed JARd plug-ins WITH source, we should remove all the signing-related garbage from the manifest.mf upon importing.

This can simply be done by reading the signed manifest and then regurgitating the keys/values and saving them

Note that the problem does not occur when importing plug-ins as binary because we already write the manifest.mf file upon importing in that mode to modify the Bundle-Classpath header.  So we should do the same here wrt reading/writing the manifest, except that we don't have to modify the Bundle-Classpath header in this case.
Comment 1 Brian Bauman CLA 2006-11-14 14:39:35 EST 
Hardest part of fixing bug was finding a signed jar, until Wassim showed me the way :)

Modified org.eclipse.pde.internal.ui.wizards.imports.PluginImportOperation.

Will be available in 3.3M4