164037 – [api] improve task editor input hierarchy

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 164037 - [api] improve task editor input hierarchy

Summary: [api] improve task editor input hierarchy

Status:	RESOLVED FIXED

Alias:	None

Product:	z_Archived
Classification:	Eclipse Foundation
Component:	Mylyn (show other bugs)
Version:	unspecified
Hardware:	PC Windows XP

Importance:	P2 enhancement (vote)
Target Milestone:	3.0
Assignee:	Steffen Pingel
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:	219912
Blocks:
	Show dependency tree

Reported:	2006-11-09 17:14 EST by Robert Elves
Modified:	2008-03-29 16:00 EDT (History)
CC List:	1 user (show)

See Also:

Attachments
first pass (82.78 KB, patch) 2008-03-15 03:27 EDT, Steffen Pingel	no flags	Details \| Diff
mylyn/context/zip (36.16 KB, application/octet-stream) 2008-03-15 03:27 EDT, Steffen Pingel	no flags	Details
cleaned up patch (77.70 KB, patch) 2008-03-15 03:29 EDT, Steffen Pingel	no flags	Details \| Diff
updated patch (80.58 KB, patch) 2008-03-29 15:47 EDT, Steffen Pingel	no flags	Details \| Diff
mylyn/context/zip (40.81 KB, application/octet-stream) 2008-03-29 15:47 EDT, Steffen Pingel	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Robert Elves

2006-11-09 17:14:19 EST

Currently NewTaskEditorInput and RepositoryTaskEditorInput extend AbstractTaskEditorInput but TaskEditorInput stands alone. This needs to be resolved and MylarTaskEditor.addPages() simplified/updated.

Comment 1 Mik Kersten

2007-01-05 14:42:55 EST

Note that while fixing bug 169018 I refactored the 3 copies of <Foo>TaskEditor.init(..) and moved the common code in AbstractRepositoryTaskEditor.init(..).

Comment 2 Robert Elves

2007-01-08 20:15:20 EST

Depends/related to bug#124321: explore making local tasks be a repository

Comment 3 Steffen Pingel

2008-02-21 03:05:05 EST

Proposal for Mylyn 3.0: Unify all editor inputs into a single input named TaskEditorInput. Simplify AbstractTaskEditorFactory to only operate on TaskEditorInput objects. Allow task editor factory to replace other factories to suppress editor tabs, e.g.: 

 String[] getSubstitutedFactoryIds().

Rob, I'll put that on my pile for now. Feel free to reassign if you would like to work on this.

Comment 4 Steffen Pingel

2008-03-15 03:27:19 EDT

Created attachment 92615 [details]
first pass

Comment 5 Steffen Pingel

2008-03-15 03:27:21 EDT

Created attachment 92616 [details]
mylyn/context/zip

Comment 6 Steffen Pingel

2008-03-15 03:29:51 EDT

Created attachment 92617 [details]
cleaned up patch

Comment 7 Robert Elves

2008-03-26 22:33:32 EDT

Proposal sounds good Stefffen!

Comment 8 Steffen Pingel

2008-03-29 15:47:48 EDT

Created attachment 94115 [details]
updated patch

Comment 9 Steffen Pingel

2008-03-29 15:47:50 EDT

Created attachment 94116 [details]
mylyn/context/zip

Comment 10 Steffen Pingel

2008-03-29 16:00:01 EDT

Committed patch. AbstractRepositoryTaskEditorInput and its subclasses will be deprecated once the new task editor is in place and AbstractRepositoryTaskEditor is deprecated.