Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 163805 - Sun's private API is used
Summary: Sun's private API is used
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P2 normal (vote)
Target Milestone: ---   Edit
Assignee: Jonathan West CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 126589
  Show dependency tree
 
Reported: 2006-11-08 09:08 EST by Pavel Dolgov CLA
Modified: 2016-05-05 11:01 EDT (History)
4 users (show)

See Also:

Attachments
Patch for Bug 163805 (1.74 KB, patch)
2010-06-25 16:32 EDT, Jonathan West CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Dolgov CLA 2006-11-08 09:08:41 EST 
The classes org.eclipse.tptp.platform.models/org.eclipse.hyades.models.common.util.FileUtil and org.eclipse.tptp.platform.common/org.eclipse.hyades.ui.internal.util.FileUtil  use the class sun.security.action.GetPropertyAction.

Proposed fix: replace the code
----------------------------------
    import sun.security.action.GetPropertyAction;
    ...
    GetPropertyAction a = new GetPropertyAction("java.io.tmpdir");
    String tmpdir = ((String)AccessController.doPrivileged(a));
----------------------------------
with following
----------------------------------
    import java.security.PrivilegedAction;
    ...
    String tmpdir = ((String)AccessController.doPrivileged(
   		new PrivilegedAction() {
	           public Object run() {
	                return System.getProperty("java.io.tmpdir");
	           }
          }));
----------------------------------
Comment 1 Ruth Lee CLA 2006-11-08 11:06:37 EST 
This should be cleaned up in 4.4. (Note that the fastXPath code is customized for each JRE, which is why it's tested against all four JREs during each test pass: Sun 1.4.2, Sun 5, IBM 1.4.2, IBM 5.)
Comment 2 Marius Slavescu CLA 2007-02-02 10:09:55 EST 
Fix in CVS.
Comment 3 Paul Slauenwhite CLA 2009-06-30 13:47:10 EDT 
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.
Comment 4 Paul Slauenwhite CLA 2009-06-30 14:13:45 EDT 
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.
Comment 5 Paul Slauenwhite CLA 2010-02-11 12:03:02 EST 
One reference still remains in org.eclipse.hyades.ui.internal.util.FileUtil.getTempDir().
Comment 6 Jonathan West CLA 2010-06-25 16:32:26 EDT 
Created attachment 172813 [details]
Patch for Bug 163805
Comment 7 Jonathan West CLA 2010-06-25 16:33:51 EDT 
Patch checked into HEAD.
Comment 8 Paul Slauenwhite CLA 2010-06-30 12:14:21 EDT 
Verified in CVS (HEAD).

Closing.