Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 162792 - [UX] Improve log import failure handling
Summary: [UX] Improve log import failure handling
Status: CLOSED WONTFIX
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P2 enhancement with 4 votes (vote)
Target Milestone: ---   Edit
Assignee: Eugene Chan CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 163437 (view as bug list)
Depends on: 163437
Blocks:
  Show dependency tree
 
Reported: 2006-10-30 15:01 EST by Jeff Calcaterra CLA
Modified: 2016-05-05 10:49 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Calcaterra CLA 2006-10-30 15:01:16 EST
Currently, log import is too unforgiving of errors and forces a user to start over from the beginining if import fails.  It also gives an error message that is too cryptic to be of much use to anyone.  The following changes should be made:

1.  Improve the error message.  The message should state that the log could not be imported and does not seem to match the adapter.

2.  Once the import fails, the log is still shown in the left navigation, but cannot be modified.  Users should be able to right-click on the file and change the filter in order to reimport the file.
Comment 1 Hendra Suwanda CLA 2006-11-04 08:51:00 EST
Add bug 163437 as a dependent.
Comment 2 Jeff Calcaterra CLA 2006-11-17 15:33:41 EST
The description below is not very clear.  Please replace with this.  I am also duping the referenced requirement.

Currently, log import is too unforgiving of errors and forces a user to start
over from the beginining if import fails.  It also gives an error message that
is too cryptic to be of much use to anyone.  The following changes should be
made:

1.  Improve the error message.  The message should state that the log could not
be imported and does not seem to match the adapter.  The messages should still be available-some users may have some use for them.

2.  Once the import fails, the log is still shown in the left navigation, but
cannot be modified.  In icon should be displayed indicating that the log failed to import (we can provide).  Users should be able to right-click on the file and go directly open the dialog that they openned in the import flow, and change the filter, version and other associated properties.

An extension point for other adapters is needed too.
Comment 3 Hendra Suwanda CLA 2006-11-17 15:35:28 EST
*** Bug 163437 has been marked as a duplicate of this bug. ***
Comment 4 Valentina Popescu CLA 2006-12-01 15:26:25 EST
Can you elaborate on step 2; I need a detailed step by step information of the expected flow. If the import log dialog opens and the user presses finish after changing this log file's properties then ALL current log set will reimported. Do you wnat to have this ? If not please explain the UI changes from a usability point of view that will help us avoid this

I also don't understand this comment 
>>>> An extension point for other adapters is needed too.
Comment 5 Eugene Chan CLA 2006-12-20 13:36:26 EST
(In reply to comment #2)
I agree the import error message should be improved, for example, explicitly say it's the wrong file type, invalid file path, etc.
However, Should a 'failed' log file instance be created in the first place when a failure of a log import happens? 
Also, if we are given user a way to re-import, should that support be provided in the error dialog (eg. button 'retry'), or as a context menu in the failed log instance? If such support is available in error dialog, we may face an issue of error dialogs of different logs in a single import show up at different time instance.
We need more information to proceed our design.
Comment 6 Hendra Suwanda CLA 2006-12-20 15:19:02 EST
(In reply to comment #5)
 
You bring up a good point. Let's discuss the scenario from the start.
1. User open the Log Import wizard, specify some log files and types (see bug 161779 also), and hit the "Import" button

2. There is some problems with the import process. There should just be one error message for the whole import step. The error message should give a list of the problematic log files and the reasons why.  Do not create the log entries (in the Navigator) for these problematic log files. In this case there is no need for the error icon in the Navigator.

3. Give the opportunity for the user to fix the problem by bringing up the wizard again if s/he chooses to do so (from the error message dialog). 
- The first page should be the "Log Files" page of the wizard
- The wizard should remember the values entered by the previous import step.
- Only the problematic log should be selected (checked) "Log Files" page. Some error indication would be needed to give visual clue to the user (icon next to the log entry)
- The user will select one problematic log and click "Edit" button 
- The "Log type" page will be shown. There should be an error message at the top of the page to indicate which error it is and how to fix it. User will fix the error.
- User will do the same with the next problematic log until all errors are fixed

Note that the flow above is based on the existing wizard. Bug 161779 may change the flow.

Let me know if this is fine.
Comment 7 Eugene Chan CLA 2007-08-09 18:29:53 EDT
raising priority per consumer's feedback.
Comment 8 Dave Smith CLA 2007-08-10 01:45:27 EDT
Resolving this as WONTFIX because it is no longer required by the consumer that
requested it.
Comment 9 Alex Nan CLA 2008-06-24 18:17:45 EDT
Closing.