Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 161066 - Non Aggregate Function Extension
Summary: Non Aggregate Function Extension
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: BIRT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 enhancement with 1 vote (vote)
Target Milestone: 2.3.1   Edit
Assignee: Rick Lu CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 227644
  Show dependency tree
 
Reported: 2006-10-16 11:01 EDT by Scott Rosenbaum CLA
Modified: 2008-07-09 22:22 EDT (History)
5 users (show)

See Also:


Attachments
The BIRT Script Function Spec. (176.00 KB, application/msword)
2008-06-16 00:58 EDT, Lin Zhu CLA
no flags Details
Example of Script Function Extension (5.78 KB, application/octet-stream)
2008-06-16 10:30 EDT, Scott Rosenbaum CLA
no flags Details
Birt Script Function Extension Spec. (171.00 KB, application/msword)
2008-06-25 23:41 EDT, Lin Zhu CLA
no flags Details
The latest spec. (173.00 KB, application/msword)
2008-07-03 23:00 EDT, Lin Zhu CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Rosenbaum CLA 2006-10-16 11:01:56 EDT
It is very easy to create aggregate functions using the ...data.aggregate extension point.  I would like to see a separate extension point that allows for the creation of non-aggergate extensions.  I realize that this can be done using standard java objects, but this creates a potential class-path issue for system administrators.  

By allowing the creation of functions through extension, all that is required is plug-in installation which is a trivial issue.  Also, using extension points would allow the functions to become a part of the BIRT Script Builder UI, with very little work on the part of the developer.
Comment 1 Lin Zhu CLA 2006-10-16 21:05:56 EDT
This is a very interesting point, and worth consideration.
Comment 2 Max CLA 2006-11-21 03:03:08 EST
A new mechanism will be introduced to make it more flexible for users to contribute custom functions on both run-time and design-time
Thanks for the advice and please be noticed this could take some time
Comment 3 Lin Zhu CLA 2007-04-09 09:29:19 EDT
After discussion we decided to defer this feature to post 2.2.
Comment 4 Scott Rosenbaum CLA 2008-04-02 22:48:39 EDT
Just checking in to see if this is going to make it for 2.3?

sr
Comment 5 Lin Zhu CLA 2008-04-03 03:26:43 EDT
Hi,

This is not going to be done in 2.3.

Thanks.
Lin
Comment 6 malcolm davis CLA 2008-04-30 17:04:05 EDT
I would like to be involved, maybe review, testing, other.

Kinds of strange, I thought the development of the existing functions would have been developed using extension points. :-) 

Comment 7 Gary Xue CLA 2008-06-02 19:51:54 EDT
Moving to 2.3.1 since we are too close to 2.3 final build to introduce new extensions. 
We will post a draft design of the new extension point to this BZ for review shortly.
Comment 8 Lin Zhu CLA 2008-06-16 00:58:02 EDT
Created attachment 104996 [details]
The BIRT Script Function Spec.
Comment 9 Scott Rosenbaum CLA 2008-06-16 10:23:04 EDT
This looks great.  I have posted it up to the BPS section of the wiki, along with some other edits of the BPS wiki.

One comment on this is that I do not see any way for the user to extend the help system.  It would be good if the extension point allowed the developer to describe the limits, parameters and usage of the function and make this part of the plug-in.  

The help should be language aware and support different language bundles.  

Comment 10 Scott Rosenbaum CLA 2008-06-16 10:26:32 EDT
Also, this is a minor issue but...

I see that there is an example that is attached to the specification document.  I would prefer to see the example zip file as a separate attachment.  I have attached the example to this bugzilla. 

If the document is updated to add information on help, please remove the zip file.

sr
Comment 11 Scott Rosenbaum CLA 2008-06-16 10:30:40 EDT
Created attachment 105030 [details]
Example of Script Function Extension

Move example out of word doc into separate attachment.
Comment 12 Scott Rosenbaum CLA 2008-06-16 10:37:12 EDT
Here is the link to the BPS doc.

http://wiki.eclipse.org/BPS101#Interested_Parties

Here is the link to the BPS Home.

http://wiki.eclipse.org/BPS101#Interested_Parties
Comment 13 Lin Zhu CLA 2008-06-25 23:38:34 EDT
Scott,

Thanks for the feedback.

For the help content issue, we already have a "desc" attribute in "Function" and "Category" elements. I have added same attribute to "Argument" element so that user can include the help info to those attribute. As this is an eclipse plugin.xml file user can also very easily i18n it.

The revised document is attached.

Thanks.
Lin
Comment 14 Lin Zhu CLA 2008-06-25 23:39:15 EDT
Comment on attachment 104996 [details]
The BIRT Script Function Spec.

This doc is obsoleted.
Comment 15 Lin Zhu CLA 2008-06-25 23:41:21 EDT
Created attachment 105854 [details]
Birt Script Function Extension Spec.
Comment 16 Lin Zhu CLA 2008-06-25 23:44:56 EDT
The corresponding wiki pages are updated.
Comment 17 Lin Zhu CLA 2008-07-03 23:00:13 EDT
Created attachment 106537 [details]
The latest spec.

Modify the spec in following aspects:
1.Remove "javaLib" element in extension schema. For we are not going to allow user to access classes defined in plugin directory. However, user can still declare their java methods(the jar of which is put into scriptlib) in extension.
2.Remove the restriction on DataType element. For the value in DataType element is purely for display purpose.

An utility method org.eclipse.birt.core.script.functionservice.impl.FunctionProvider has been provided to UI for the display of functions in expression builder.Reassign the bug to UI team for further fixes.
Comment 18 Chen Chao CLA 2008-07-08 23:30:41 EDT
Fixed the ui designer part.

Model should remove ths duplicated part. Reassign it to model. 
Comment 19 Chen Chao CLA 2008-07-08 23:31:49 EDT
Fixed the ui designer part.

Model should remove ths duplicated part. Reassign it to model. 
Comment 20 Rick Lu CLA 2008-07-09 04:58:48 EDT
Need to remove BirtComp, DateTimeSpan and Finance class information from ROM.
Comment 21 Rick Lu CLA 2008-07-09 22:22:58 EDT
Fixed