This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 160968 - Add 'removeListener' methods where needed
Summary: Add 'removeListener' methods where needed
Status: CLOSED FIXED
Alias: None
Product: ECF
Classification: RT
Component: ecf.doc (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: ecf.doc-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-10-14 19:29 EDT by Scott Lewis CLA
Modified: 2008-05-18 14:46 EDT (History)
0 users

See Also:

Attachments
Patch to add a removeListener(ICallSessionListener) for ICallContainer. (982 bytes, patch)
2006-10-19 05:00 EDT, Remy Suen CLA 		no flags Details | Diff
Jingle API fragment project at ecf1.osuosl.org (267 bytes, text/plain)
2006-10-19 09:51 EDT, Scott Lewis CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Lewis CLA 2006-10-14 19:29:52 EDT 
In some locations, only 'addListener' methods are available on a given interface/class (e.g. IChatRoomContainer.addMessageListener and addChatParticipantListener).  Symmetric 'removeListener' methods should be added in these places and implemented in implementations.  (e.g. IChatRoomContainer.removeMessageListener, and IChatRoomContainer.removeChatParticipantListener).  Note that the convention for 'removeListener' methods is that the method returns 'true' if listener found and removed, 'false' if not found/nothing removed.
Comment 1 Remy Suen CLA 2006-10-19 05:00:48 EDT 
Created attachment 52297 [details]
Patch to add a removeListener(ICallSessionListener) for ICallContainer.

Better add this method in for ICallContainer before implementors comes into play since I noticed the Jingle stuff seems to be starting to get committed to CVS. The less interface implementations to fix the better. :)
Comment 2 Scott Lewis CLA 2006-10-19 09:51:00 EDT 
Created attachment 52313 [details]
Jingle API fragment project at ecf1.osuosl.org
Comment 3 Scott Lewis CLA 2006-10-19 23:14:18 EDT 
Fixed with checkins on 10/19/2006.  Will be in 0.9.3 stable release
Comment 4 Scott Lewis CLA 2006-11-16 14:03:49 EST 
closing and adding to ip log for patch