Community
Participate
Working Groups
Per the discussion that's been going on the ecf-dev mailing list [1], major restructuring work is needed for the org.eclipse.ecf.example.collab plug-in. Required actions that have been identified thus far include the abstraction of the provider IContainer connecting functionality and the definition of common UI components so that an Eclipse-based plug-in and RCP application that makes use of ECF providers can be deployed for users. [1] http://dev.eclipse.org/mhonarc/lists/ecf-dev/msg00386.html
Created attachment 52636 [details] Workspace-level patch to modify org.eclipse.ecf.ui and org.eclipse.ecf.example.collab. This patch will essentially do an "Organize Imports" on relevant files in addition to altering the collab UI to use the new ConnectionDialog that I rewrote/updated. Auto login is no longer included since I felt that saving passwords in plain text is a pretty large security leak. You have to move the default_provider_image.gif file from the icons folder in the collab plug-in to the ui plug-in to prevent an NPE when opening the dialog. No warnings are provided for missing usernames/passwords since I came to realize that you don't have to have a password for IRC. So only the connection ID must be filled in, otherwise the 'OK' button will be enabled.
Created attachment 52637 [details] Zip file that contains org.eclipse.ecf.ui.im and org.eclipse.ui.im.services. The discovery stuff went to ui.services and the presence stuff went to ui.im. I noticed that the collab plug-in actually extends the DiscoveryView. But at the moment I also have the DiscoveryView being declared as a ViewPart extension within ui.services' plugin.xml file. I suppose the question is whether DiscoveryView is actually supposed to be subclassed by clients or not, or maybe it should be abstract? So to execute this on your workspace: 1. Unzip projects.zip (this attachment) into your workspace 2. Create the org.eclipse.ecf.ui.im and org.eclipse.ecf.ui.services projects within Eclipse. 3. Apply attachment #52636 [details] to your workspace to modify org.eclipse.ecf.ui and org.eclipse.ecf.example.collab. 4. Cut/Copy default_provider_image.gif from the collab plug-in's 'icons' folder to the ui plug-in's 'icons' folder. Other example plug-ins / RCP applications will probably be affected by this change, but a run of "Organize Imports" after adding ui.im and/or ui.services to their MANIFEST.MF dependencies should fix the problem.
Refactoring started. Moved many classes into internal packages. TBC.
(In reply to comment #3) > Refactoring started. Moved many classes into internal packages. TBC. > Continued move to internal packages. Removed extraneous/no longer used methods, classes, interfaces. Renamed method and field names for simplicity and consistency. Resolving as Fixed.
Reopening to deal with package visibility issues.
Moving to 2.0.0M4 target milestone.
Did some mild refactoring to make the send screen capture capability work reliably with very large images. Added zip compression for image data and simplified some existing code in org.eclipse.ecf.examples.collab.
Resolving as fixed as per comment 7. More work remains on this, but unlikely to occur given current resources. If committer or contributor resources become available, then please reopen.
