Community
Participate
Working Groups
Created attachment 51705 [details] EH facility - first steps
I have the following comments if (workbenchErrorHandler == null) { workbenchErrorHandler = new WorkbenchErrorHandler(); } return workbenchErrorHandler; this code will create a WorkbenchErrorHandler is there isn't one specified. Where do you look in the registry? What is ErrorDialog in the ide for? Don't shortcut the names of classes. Use ErrorHandler everywhere not EH. People can read faster than they can parse. It is very hard to follow uncommented code. Please comment everything even if it is a draft. We need a better name than whineMode. Perhaps reportingLevel or something like that. whine is too conversational /* * (Intentionally not javadoc'd) Implements the corresponding method on * <code>IStatus</code>. */ should use the default template here. The schema should be clearer about how parameters are used. maybe extending the example would make it clearer.
Created attachment 51748 [details] New test project for new error handling facility
Created attachment 51751 [details] Error handling facility - first steps
Created attachment 51843 [details] EH facility Changes to API. Documentation improved.
Created attachment 51844 [details] Error handler schema
As we all agreed the word 'error' in the name of the facility isn't good. We have to rename it and all parts which have 'error' in names. The reason is that the facility isn't only for error statuses but it can handle others as well. So I suggest to call it Status Handling and I'm waiting for other suggestions... Of course all error handlers will be called status handlers.
Created attachment 53149 [details] Status Handling Fac. 2006-11-02 The name of the facility changed into 'Status handling facility'
Some comments AbstractStatusHandler needs better javadoc for it's getters and setters so that implementors know what they are doing. Same issue for StatusHandlingState IDEWorkbenchAdvisor has some commented out code and some strange formatting of comments. We should tidy this up org.eclipse.ui.errors should likely be renamed org.eclipse.ui.status to reflect the name changes the schema should avoid things like "so far" in the comment. If we are planning to do more we don't need to confuse the user with vague promises. The Englush needs cleaning up but I can do that.
Patch released with some small changes of naming etc. for build >20061107
Created attachment 53811 [details] Status Handling Fac. 2006-11-14 EXPERIMENTAL tag added schema error fixed (html tag <code> wasn't closed)
