Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 159926 - (1.5.3) HTMLAttributeValidator has reversed JSP-aware attribute name and value checks?
Summary: (1.5.3) HTMLAttributeValidator has reversed JSP-aware attribute name and valu...
Status: CLOSED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.html (show other bugs)
Version: 1.5   Edit
Hardware: PC Windows XP
: P2 major (vote)
Target Milestone: 1.5.3 M153   Edit
Assignee: Amy Wu CLA
QA Contact: David Williams CLA
URL:
Whiteboard:
Keywords:
Depends on: 143209
Blocks:
  Show dependency tree
 
Reported: 2006-10-05 15:18 EDT by Amy Wu CLA
Modified: 2007-01-03 11:52 EST (History)
2 users (show)

See Also:

Attachments
org.eclipse.jst.jsp.ui.tests.patch (18.99 KB, patch)
2006-11-07 18:02 EST, Amy Wu CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Amy Wu CLA 2006-10-05 15:18:46 EDT 
+++ This bug was initially created as a clone of Bug #143209 +++

The code in org.eclipse.wst.html.core.internal.validate.HTMLAttributeValidator.validate(IndexedRegion) contains a couple of branches where it could report unknown names and attributes, but it will only do so on JSP regions.  Shouldn't it be reversed to report them as unknown names and values when it's *not* a JSP region?
Comment 1 Amy Wu CLA 2006-10-05 15:21:44 EDT 
This bug was created to track putting the fix for bug 143209 (which has been put in wtp 2.0 m2) into wtp 1.5.3.
Comment 2 David Williams CLA 2006-10-26 04:50:42 EDT 
mass update to remove target for all those targeted to 1.5.3 that were "normal" severity and "priority 3" (on the surface those dont' seem serious enough to fix in a maintenance release). 

If I have made an error pleasae reset target and set priority appropriately.
Comment 3 Amy Wu CLA 2006-10-26 11:12:45 EDT 
Increasing severity & priority and retargetting to 1.5.3.  

Having jsp code as html attributes is pretty common.  The HTML validator is currently working backwards in regards to validating jsp code in html attributes (saying code is wrong when it is right, and saying code is right when it is wrong)
Comment 4 Amy Wu CLA 2006-11-07 18:02:55 EST 
Created attachment 53421 [details]
org.eclipse.jst.jsp.ui.tests.patch

This is a patch to add some unit tests to check that jsp tags in html attributes are valid.
Comment 5 Amy Wu CLA 2006-11-07 18:04:36 EST 
The actual code fix patch is exactly the same as what is in bug 143209.  The only additional modification was to up the plugin version number.
Comment 6 Amy Wu CLA 2006-11-08 15:51:19 EST 
fix released to 1.5.3.  should be in builds > 200611090100
Comment 7 Amy Wu CLA 2007-01-03 11:52:58 EST 
verified in WTP1.5.3 SDK 200611291828